fix(user): properly handle null param in whereName() #3142

wescopeland · 2025-01-26T23:08:24Z

Currently, if the given display name param is null, the first user on the table (Scott) will get grabbed instead, ie:

$this->userContext = User::whereName($targetUsername)->first() ?? Auth::user() ?? null;

In the case of the bug reported, $targetUsername is null, so Scott's user record is being pulled by the query.

fix(user): properly handle null param in whereName()

75af6f2

wescopeland requested a review from a team January 26, 2025 23:08

Jamiras approved these changes Jan 28, 2025

View reviewed changes

Merge branch 'master' into where-name-null-fix

ec0f39a

wescopeland merged commit 389af48 into RetroAchievements:master Jan 28, 2025
8 checks passed

wescopeland deleted the where-name-null-fix branch January 28, 2025 22:30

wescopeland mentioned this pull request Jan 30, 2025

[Bug] Ridge Racer Turbo shown as beaten without playing it #3155

Closed

wescopeland added a commit that referenced this pull request Feb 2, 2025

fix(user): properly handle null param in whereName() (#3142)

9bc3a95

Provide feedback