Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(messages): cut over to the React messages index #3140

Merged

Conversation

wescopeland
Copy link
Member

@wescopeland wescopeland commented Jan 26, 2025

Deletes the Folio page and cuts over to React.

Additionally, adds a performance optimization to the page. Currently in master, each message is being loaded per record when we really only need the most recent one (to determine the most recent createdAt timestamp). Now, we only load the message associated with last_message_id to make this determination.

@wescopeland wescopeland requested a review from a team January 26, 2025 21:08
@wescopeland wescopeland marked this pull request as draft January 27, 2025 14:07
@wescopeland wescopeland marked this pull request as ready for review January 27, 2025 21:08
@wescopeland wescopeland merged commit 88e9db7 into RetroAchievements:master Jan 29, 2025
8 checks passed
@wescopeland wescopeland deleted the react-messages-cutover branch January 29, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants