Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect alternate core label #3128

Merged
merged 2 commits into from
Jan 26, 2025
Merged

detect alternate core label #3128

merged 2 commits into from
Jan 26, 2025

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Jan 25, 2025

Apparently, IOS labels the cores "core.libretro" instead of "core_libretro"

https://discord.com/channels/476211979464343552/1002689485005406249/1332717032055115897

wescopeland
wescopeland approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the change locally, but it seems reasonable and the tests prove that it works.

@Jamiras Jamiras merged commit 853ea5a into RetroAchievements:master Jan 26, 2025
8 checks passed
@Jamiras Jamiras deleted the bugfix/ios_useragent_core branch January 26, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wescopeland wescopeland wescopeland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jamiras @wescopeland