fix: address feedback

RetroAchievements · Jan 26, 2025 · 3b4901f · 3b4901f
1 parent 27cdb09
commit 3b4901f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/app/Platform/Services/GameSuggestions/Strategies/CommonPlayersStrategy.php b/app/Platform/Services/GameSuggestions/Strategies/CommonPlayersStrategy.php
@@ -39,7 +39,7 @@ public function select(): ?Game
             ->whereAllAchievementsUnlocked()
             ->where('achievements_total', '>', 0)
             ->where('game_id', '!=', $this->sourceGame->id)
-            ->whereNull('deleted_at')
+            ->withTrashed()
             ->groupBy('game_id')
             ->orderByRaw('COUNT(*) DESC')
             ->limit(10)
@@ -96,7 +96,7 @@ private function getMasterUserIdsMariaDB(): Collection
             ->where('game_id', $this->sourceGame->id)
             ->where('user_id', '!=', $this->user->id)
             ->whereAllAchievementsUnlocked()
-            ->whereNull('deleted_at')
+            ->withTrashed()
             ->whereRaw('id % 100 < 5')
             ->limit(5)
             ->pluck('user_id');
@@ -112,7 +112,7 @@ private function getMasterUserIdsSQLite(): Collection
         return PlayerGame::where('game_id', $this->sourceGame->id)
             ->where('user_id', '!=', $this->user->id)
             ->whereAllAchievementsUnlocked()
-            ->whereNull('deleted_at')
+            ->withTrashed()
             ->orderByRaw('rowid % 100')
             ->limit(5)
             ->pluck('user_id');

diff --git a/database/migrations/2025_01_25_000000_update_player_games_table.php b/database/migrations/2025_01_25_000000_update_player_games_table.php
@@ -14,7 +14,6 @@ public function up(): void
                 'user_id',
                 'achievements_unlocked',
                 'achievements_total',
-                'deleted_at',
                 'game_id',
             ], 'idx_player_games_suggestions'); // custom name needed because the auto-generated one is too long
         });