Fix DuplicateSlot ProtoFlux node crashing game when if OverrideParent is identical to Template #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is identical to Template Yellow-Dog-Man/Resonite-Issues#3950
Contributor
|
From Claude AI: The overall effect is that any check using Slot.IsChildOf() in the patched method will always return true, regardless of what the original method would have returned. This effectively bypasses parent-child relationship validation, making the code behave as if any slot is always a child of whatever slot it's being compared to. |
Contributor
Author
|
Did you test this? The transpiler just changes the second argument of IsChildOf from false to true so that it considers the slot itself a child too |
Contributor
|
I did not test it but now I see what it does |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a fix for Yellow-Dog-Man/Resonite-Issues#3950