Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto container release action #200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhiemstrawisc
Copy link
Collaborator

Now whenever a new tag of SPRAS is pushed to github, the corresponding container from that tag is build and pushed to Dockerhub.

Now whenever a new tag of SPRAS is pushed to github, the corresponding
container from that tag is build and pushed to Dockerhub.
@jhiemstrawisc jhiemstrawisc requested a review from agitter December 9, 2024 21:56
Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to decide on the tagging convention. Then we can merge and test it by making a release.

- name: Log in to Docker Hub
uses: docker/login-action@v1
with:
username: ${{ vars.DOCKER_USERNAME }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out I added a DockerHub personal access token to this repository in 2021 and forgot about it
image

Comment on lines +9 to +10
# run release on any version tag vX.Y.Z, e.g. v0.2.1
- v[0-9]+\.[0-9]+\.[0-9]+
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our tags so far have not had a leading v. Should we keep that convention and change the pattern here?

@@ -0,0 +1,43 @@
name: Release SPRAS on new tags
# This action runs whenever a new tag matching vX.Y.Z is pushed to the repo.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust depending on what we decide below regarding tag pattern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants