Node3D editor: Added tooltips for Grid Snap and Local Space transform toggles #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the Node3d editor.
lukechen0129
approved these changes
Oct 5, 2024
|
Does this have a Godot PR and/or proposal? Also is it alright to push this upstream to Godot, or would @TheEclectus prefer that it not be? |
|
@Spartan322 It seems to have a Godot PR. The issue seems to have been a regression in tooltips not showing on Controls unless a descriptive tooltip text was set as well, so unfortunately my fix (as it currently exists) is just a bandaid solution, and timothyqiu's PR would fix the root cause |
|
That PR was merged 2 hours ago, in that case should this be closed then? As it will be fixed in the next merge with upstream. |
|
Yup, I'll close it up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very small PR to fix a lingering inconsistency with the buttons in the Node3D editor view, in that the Use Local and Grid Snap toggles didn't have tooltips when hovered.
The results:
