-
Notifications
You must be signed in to change notification settings - Fork 335
MOD-9169 Do not double count used capacity of containers in memory stats #1329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ephraimfeldblum
merged 6 commits into
master
from
ephraim_undo-double-counting-of-used-capcity-in-containers
Mar 25, 2025
Merged
MOD-9169 Do not double count used capacity of containers in memory stats #1329
ephraimfeldblum
merged 6 commits into
master
from
ephraim_undo-double-counting-of-used-capcity-in-containers
Mar 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1329 +/- ##
==========================================
- Coverage 78.37% 78.11% -0.26%
==========================================
Files 15 15
Lines 4004 3871 -133
==========================================
- Hits 3138 3024 -114
+ Misses 866 847 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MeirShpilraien
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOD-9169
re redis/docs#1305
Some memory of JSON values is double counted when stored in containers (arrays or objects). They are accounted for once in the capacity of the container, and then again when recursively counting the used memory of the values stored within the container.
Fix:
Separate the top-level call from recursive calls to
get_memory()
. The top-level object must account for its ownsize_of::<IValue>()
. Any recursive call made have already accounted for that memory, so they do not need to add it in.