Skip to content

Conversation

@nikajorjika
Copy link
Contributor

This pull request refactors the message store configuration to use a new inbox namespace, adds support for custom store resolvers, and updates the contract and tests for MessageStore. The changes improve flexibility in configuring storage drivers and make it easier to inject custom implementations.

Configuration and custom resolvers:

  • The message store configuration is migrated from the old mailbox-for-laravel namespace to the new inbox namespace in config/inbox.php, including support for a new resolvers array for custom stores.
  • The StoreManager class now checks for a custom resolver in inbox.store.resolvers before falling back to built-in drivers, using a new resolveCustomStore method.

Contract and test updates:

  • The MessageStoreContractTest now expects the MessageStore contract to define update and clear methods in addition to existing methods. [1] [2]
  • The StoreManagerTest is updated to use the new inbox configuration keys and tests custom store resolver logic, as well as the passing of configuration options to store implementations. [1] [2]

@nikajorjika nikajorjika requested a review from Copilot September 21, 2025 07:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request modernizes the message store configuration system by migrating from the mailbox-for-laravel namespace to a new inbox namespace and adds support for custom store resolvers. The changes improve flexibility in configuring storage drivers and make it easier to inject custom implementations.

  • Migrates configuration from mailbox-for-laravel namespace to inbox namespace
  • Adds support for custom store resolvers through a new resolvers configuration array
  • Updates the MessageStore contract to include update and clear methods

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
config/inbox.php Adds new resolvers configuration array for custom store implementations
src/StoreManager.php Refactors to use new config namespace and implements custom resolver logic
tests/Unit/StoreManagerTest.php Updates test configuration keys and adds test coverage for new methods
tests/Unit/Contracts/MessageStoreContractTest.php Updates contract test to include new required methods

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nikajorjika nikajorjika merged commit 9bab49e into main Sep 21, 2025
1 of 25 checks passed
@nikajorjika nikajorjika deleted the fix/test-cases-fail-reasons branch September 21, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants