DRAFT: test(IQE-3855): Update user configuration in IQE plugin#3833
Draft
mshriver wants to merge 2 commits intoRedHatInsights:masterfrom
Draft
DRAFT: test(IQE-3855): Update user configuration in IQE plugin#3833mshriver wants to merge 2 commits intoRedHatInsights:masterfrom
mshriver wants to merge 2 commits intoRedHatInsights:masterfrom
Conversation
the yaml for users is old in this plugin and needs an attributes block in addition, the patterns around the old user processing and mutating could use some work. Co-authored-by: Claude <noreply@anthropic.com>
Contributor
SC Environment Impact AssessmentOverall Impact: ⚪ NONE No SC Environment-specific impacts detected in this PR. What was checkedThis PR was automatically scanned for:
|
mshriver
commented
Mar 25, 2026
| org_id: | ||
| vault_path: secrets/qe/prod/users/insights_inventory_qe | ||
| vault_key: org_id | ||
| email: "insights_inventory_qe@redhat.com" |
Contributor
Author
There was a problem hiding this comment.
@fstavela I'd like to put the actual email into vault and use a ref here.
Moving all fields into vault and we can use the new !credential hook in iqe-core.
Contributor
There was a problem hiding this comment.
I've added the email to vault
add deprecation warning when legacy user handling path is hit Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the yaml for users is old in this plugin and needs an attributes block
in addition, the patterns around the old user processing and mutating could use some work.
Iterating on adopting the new UserLike protocol for more stable typing.
Overview
This PR is being created to address RHINENG-xxxx.
(A description of your PR's changes, along with why/context to the PR, goes here.)
PR Checklist
Secure Coding Practices Documentation Reference
You can find documentation on this checklist here.
Secure Coding Checklist
Summary by Sourcery
Adopt typed user configuration in the IQE host-inventory plugin and update user handling to support the new UserLike-based attributes model while preserving compatibility with legacy identity configs where needed.
New Features:
Enhancements:
Tests: