feat: migrate to v2 pipeline with flexible secret management#760
Draft
catastrophe-brandon wants to merge 9 commits intoRedHatInsights:masterfrom
Draft
Conversation
Migrates from v1 to v2 platform-ui pipeline to enable flexible secret management without requiring pipeline modifications. Changes: - Update pipeline reference to v2 (docker-build-run-all-tests-v2.yaml) - Point to catastrophe-brandon/konflux-pipelines fork (branch: btweed/platform-ui-v2-flexible-secrets) - Add migration guide documentation Benefits: - Can now add custom secrets (Chromatic, Currents, etc.) by only updating ExternalSecret - Backwards compatible with existing e2e-credentials-secret - All secret keys automatically available as environment variables The v2 pipeline uses envFrom for automatic secret loading while maintaining explicit mappings for backwards compatibility (HCC_ENV_URL, STAGE_ACTUAL_HOSTNAME). See .tekton/V2_PIPELINE_MIGRATION.md for details. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Author
|
/retest |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Add envFrom configuration to pull e2e test credentials from secret and set Currents environment variables for test result uploads. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The step name is 'e2e-tests', not 'run-e2e-tests'. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The secret uses 'currents-record-key' as the key name, but Currents expects the environment variable to be named 'CURRENTS_RECORD_KEY'. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Verify that CURRENTS_RECORD_KEY is set before attempting to run Playwright tests to provide a clear error message if the secret isn't configured correctly. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The shared pipeline already has envFrom configured to import secrets. The stepSpecs override was redundant and potentially conflicting. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The secret key 'currents-record-key' contains hyphens and won't be imported via envFrom. Need explicit mapping to convert it to valid env var name CURRENTS_RECORD_KEY. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates from v1 to v2 platform-ui pipeline to enable flexible secret management without requiring pipeline modifications. Flexible secret management is a requisite to unlock easy setup of data uploads to tools like Chromatic, Currents.dev, or any tool of the consumer's choosing that requires specific secrets configuration.
Changes:
Benefits:
The v2 pipeline uses envFrom for automatic secret loading while maintaining explicit mappings for backwards compatibility (HCC_ENV_URL, STAGE_ACTUAL_HOSTNAME).
See .tekton/V2_PIPELINE_MIGRATION.md for details.
Description
description text...
RHCLOUDXXXX
Screenshots
Before:
After:
Checklist ☑️