Skip to content

feat(RHINENG-25206): Normalize FEO config#339

Open
hugohezel wants to merge 1 commit intoRedHatInsights:mainfrom
hugohezel:hhezel/RHINENG-25206
Open

feat(RHINENG-25206): Normalize FEO config#339
hugohezel wants to merge 1 commit intoRedHatInsights:mainfrom
hugohezel:hhezel/RHINENG-25206

Conversation

@hugohezel
Copy link
Copy Markdown

@hugohezel hugohezel commented Apr 8, 2026

Related ticket: RHINENG-25206

Description

  • Normalized FEO paths to use leading slashes across navigation, search, and routing entries
  • Restored missing Activation Keys search aliases (alt_title) from the legacy static search index

How to test

  • Verify Activation Keys is accessible from the left navigation, from global search, and directly via /insights/connector/activation-keys
  • Verify global search also finds Activation Keys using restored aliases such as subscription key and simple content access

Summary by Sourcery

Normalize Activation Keys frontend configuration paths and enhance its search discoverability.

New Features:

  • Add alternative search titles for Activation Keys to improve discoverability in global search.

Enhancements:

  • Standardize Activation Keys navigation, search, and route paths to use leading slashes in the frontend configuration.

@hugohezel hugohezel requested a review from a team as a code owner April 8, 2026 07:25
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 8, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Normalizes the Activation Keys FEO configuration to use leading slashes for all routes and restores legacy search aliases for Activation Keys in the frontend deployment config.

Sequence diagram for Activation Keys access via global search

sequenceDiagram
    actor User
    participant GlobalSearch as GlobalSearchUI
    participant FEOConfig as FEOConfig
    participant Router as FrontendRouter
    participant ActivationKeys as ActivationKeysApp

    User->>GlobalSearch: Type query (e.g. "subscription key")
    GlobalSearch->>FEOConfig: Match query against searchEntries.alt_title
    FEOConfig-->>GlobalSearch: Return id activation-keys and href /insights/connector/activation-keys
    User->>GlobalSearch: Select Activation Keys result
    GlobalSearch->>Router: Navigate to /insights/connector/activation-keys
    Router->>ActivationKeys: Load module activation-keys with route /insights/connector/activation-keys
    ActivationKeys-->>User: Render Activation Keys page
Loading

Flow diagram for normalized FEO config paths for Activation Keys

flowchart TD
    FEORoot[FEO frontend.yaml]

    FEORoot --> SearchEntries[searchEntries activation-keys]
    FEORoot --> NavItems[bundleSegments connector-activation-nav navItems activation-keys]
    FEORoot --> Routes[module activation-keys routes]

    SearchEntries --> SEHref[/href /insights/connector/activation-keys/]
    NavItems --> NavHref[/href /insights/connector/activation-keys/]
    Routes --> RoutePath[/pathname /insights/connector/activation-keys/]

    SearchEntries --> AltTitle[alt_title aliases
subscription key
sca
simple content access
activate
register
AK
repositories
system purpose
sla
content]
Loading

File-Level Changes

Change Details Files
Normalize Activation Keys URLs in FEO config to use leading slashes consistently across search, navigation, and routing.
  • Updated search entry href to include a leading slash for the Activation Keys path.
  • Updated left navigation item href to include a leading slash for the Activation Keys path.
  • Updated module route pathname to include a leading slash for the Activation Keys path.
deploy/frontend.yaml
Restore legacy search aliases for Activation Keys to improve discoverability in global search.
  • Added alt_title aliases such as subscription key, sca, simple content access, and related terms under the Activation Keys search entry.
deploy/frontend.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • Consider extracting /insights/connector/activation-keys into a shared value so the search entry, nav item, and route all reference the same path constant to avoid future drift.
  • The description for the Activation Keys search entry currently says Assign and manager activation keys.; this looks like a typo and should probably be Assign and manage activation keys..
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider extracting `/insights/connector/activation-keys` into a shared value so the search entry, nav item, and route all reference the same path constant to avoid future drift.
- The description for the Activation Keys search entry currently says `Assign and manager activation keys.`; this looks like a typo and should probably be `Assign and manage activation keys.`.

## Individual Comments

### Comment 1
<location path="deploy/frontend.yaml" line_range="27" />
<code_context>
           title: Activation Keys
-          href: insights/connector/activation-keys
+          href: /insights/connector/activation-keys
           description: Assign and manager activation keys.
+          alt_title:
+            - Subscription key
</code_context>
<issue_to_address>
**suggestion (typo):** Fix the wording in the description to use the correct verb form.

This should read "Assign and manage activation keys." to be grammatically correct in this user-facing text.

```suggestion
          description: Assign and manage activation keys.
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

title: Activation Keys
href: insights/connector/activation-keys
href: /insights/connector/activation-keys
description: Assign and manager activation keys.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (typo): Fix the wording in the description to use the correct verb form.

This should read "Assign and manage activation keys." to be grammatically correct in this user-facing text.

Suggested change
description: Assign and manager activation keys.
description: Assign and manage activation keys.

@hugohezel hugohezel force-pushed the hhezel/RHINENG-25206 branch from 5d6273a to dce7177 Compare April 8, 2026 07:31
@hugohezel
Copy link
Copy Markdown
Author

hugohezel commented Apr 8, 2026

teamnado please confirm that restoring these aliases is desired.
Also, the legacy search index entry used a broader description: "Create activation keys to register your systems and configure repositories without using a username and password."

@hugohezel
Copy link
Copy Markdown
Author

hugohezel commented Apr 8, 2026

Left bar navigation (bundleSegments) is not tied to the correct bundleId (should be insights). However, I'm doublecheking whether we should define bundleSegments at all since it is already covered by insights-inventory-frontend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant