feat(RHINENG-25206): Normalize FEO config#339
feat(RHINENG-25206): Normalize FEO config#339hugohezel wants to merge 1 commit intoRedHatInsights:mainfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideNormalizes the Activation Keys FEO configuration to use leading slashes for all routes and restores legacy search aliases for Activation Keys in the frontend deployment config. Sequence diagram for Activation Keys access via global searchsequenceDiagram
actor User
participant GlobalSearch as GlobalSearchUI
participant FEOConfig as FEOConfig
participant Router as FrontendRouter
participant ActivationKeys as ActivationKeysApp
User->>GlobalSearch: Type query (e.g. "subscription key")
GlobalSearch->>FEOConfig: Match query against searchEntries.alt_title
FEOConfig-->>GlobalSearch: Return id activation-keys and href /insights/connector/activation-keys
User->>GlobalSearch: Select Activation Keys result
GlobalSearch->>Router: Navigate to /insights/connector/activation-keys
Router->>ActivationKeys: Load module activation-keys with route /insights/connector/activation-keys
ActivationKeys-->>User: Render Activation Keys page
Flow diagram for normalized FEO config paths for Activation Keysflowchart TD
FEORoot[FEO frontend.yaml]
FEORoot --> SearchEntries[searchEntries activation-keys]
FEORoot --> NavItems[bundleSegments connector-activation-nav navItems activation-keys]
FEORoot --> Routes[module activation-keys routes]
SearchEntries --> SEHref[/href /insights/connector/activation-keys/]
NavItems --> NavHref[/href /insights/connector/activation-keys/]
Routes --> RoutePath[/pathname /insights/connector/activation-keys/]
SearchEntries --> AltTitle[alt_title aliases
subscription key
sca
simple content access
activate
register
AK
repositories
system purpose
sla
content]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Consider extracting
/insights/connector/activation-keysinto a shared value so the search entry, nav item, and route all reference the same path constant to avoid future drift. - The description for the Activation Keys search entry currently says
Assign and manager activation keys.; this looks like a typo and should probably beAssign and manage activation keys..
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting `/insights/connector/activation-keys` into a shared value so the search entry, nav item, and route all reference the same path constant to avoid future drift.
- The description for the Activation Keys search entry currently says `Assign and manager activation keys.`; this looks like a typo and should probably be `Assign and manage activation keys.`.
## Individual Comments
### Comment 1
<location path="deploy/frontend.yaml" line_range="27" />
<code_context>
title: Activation Keys
- href: insights/connector/activation-keys
+ href: /insights/connector/activation-keys
description: Assign and manager activation keys.
+ alt_title:
+ - Subscription key
</code_context>
<issue_to_address>
**suggestion (typo):** Fix the wording in the description to use the correct verb form.
This should read "Assign and manage activation keys." to be grammatically correct in this user-facing text.
```suggestion
description: Assign and manage activation keys.
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| title: Activation Keys | ||
| href: insights/connector/activation-keys | ||
| href: /insights/connector/activation-keys | ||
| description: Assign and manager activation keys. |
There was a problem hiding this comment.
suggestion (typo): Fix the wording in the description to use the correct verb form.
This should read "Assign and manage activation keys." to be grammatically correct in this user-facing text.
| description: Assign and manager activation keys. | |
| description: Assign and manage activation keys. |
5d6273a to
dce7177
Compare
|
teamnado please confirm that restoring these aliases is desired. |
|
Left bar navigation ( |
Related ticket: RHINENG-25206
Description
alt_title) from the legacy static search indexHow to test
/insights/connector/activation-keyssubscription keyandsimple content accessSummary by Sourcery
Normalize Activation Keys frontend configuration paths and enhance its search discoverability.
New Features:
Enhancements: