Skip to content

features: define a custom folder for the summaries and transcriptions, pretty formatting for the markdown export, use openai compatible endpoints, CLI to build and run the project locally, ... #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 66 commits into
base: main
Choose a base branch
from
Open

features: define a custom folder for the summaries and transcriptions, pretty formatting for the markdown export, use openai compatible endpoints, CLI to build and run the project locally, ... #16

wants to merge 66 commits into from

Conversation

@nilleb
Copy link

@nilleb nilleb commented Oct 3, 2025 •
edited
Loading

Description

I do not expect you to merge this, Rawa, but I wanted to show you what I did - and let you pick the features you like.
Just name the features you'd like to have merged and I'll try to do that.

The features present in this branch

  • the system tray icon now changes color during recordings
  • the system tray icon has a menu where to access a few options
    • Start|Stop recording (cmd+R)
    • Settings
    • Drag & Drop a recording and get the summary/transcription
    • Quit (cmd+Q)
    • shortcuts (configurable) for start/stop recording
    • use an openai model (hosted on the official API or on a Azure instance)
    • button to test the llm endpoint
    • the icon changes color according to the system tray settings (dark/light mode)
    • define a storage location for the recordings/transcripts/summaries (useful for Obsidian integration)
    • markdown format for the transcriptions, prettified
    • the recap window allows you to retry the transcription / summarization (in case of errors) and even mark the recording as complete if the recording is not recoverable
    • rationalized the panels (recording sources now go to the general settings, recaps are accessed directly through the menu)
    • all the ilnter issues of the project have been fixed
    • the unit tests are passing

Notable fixes:

  • connecting bluetooth devices was preventing the recording from starting (because of an incorrect sampling frequency)

All this has been done with Claude/Codex/Cursor (with little supervision of my own)

All the best

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test improvement

Testing

  • Unit tests pass locally
  • New tests have been added for new functionality
  • Existing tests have been updated if needed

Checklist

  • I have performed a self-review of my own code
  • I have commented my code where necessary (following the no-comments rule)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

Ivo Bellin Salarin and others added 30 commits October 3, 2025 13:31
fix: stuff
1a58de6
fix: upgrade the project to most recent xcode
f6737b0
@GitWither
Add a dropdown that shows the transcript in the recording summary
e167098
@GitWither
Implement code review changes, reuse defined color constants
298b3c2
fix: stuff
339298c
fix: upgrade the project to most recent xcode
8aaaa0b
@wobondar
feat: Add System-Wide audio tap recording functionality
869de69
fix: recording the system audio at last
7e6950c
feat: copy transcript and timestamps
3f34a82
feat: dark theme icon
34a8e70
feat: cli and gitignore
68614f0
fix: tests
bdaf31f
chore: always use the black icon on the system tray
37f33f2
@claude
WIP: system tray revised changes
dcf4e03 
🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
feat: vad
7629593
feat: system tray icon switches to red, merge the vad branch and avoi…
9c05566 
…d crashes
WIP: VAD dumps now contain text!
19b368a
feat: enable VAD for the system audio too
ed5cdd1
feat: vad for system audio and pretty transcriptions
cac6039
chore: close icon color
3534e1d
feat: access recaps and settings independently
455a94f
feat: global shortcut settings
dcc5266
feat: select a destination folder in the user directory
e231c14
feat: apply prettifier to transcriptions, transcribe segments and who…
a8b587f 
…le recording
chore: remove UI hacks, rationalize settings
2b989c6
feat: prepare a redistributable package
23dcbd8
feat: cli run
e7d2924
feat: option to disable segments transcript and summarization
4c72da8
feat: remove the VAD
3266dcc
feat: specify the configuration
d462078
Ivo Bellin Salarin and others added 22 commits October 3, 2025 14:04
fix: unit tests
d14b448
chore: unit tests guidance
76b658f
chore: swiftlint
09ccbbb
fix: connect a bluetooth device after startup
da2bd2d 
the sampling rate differs from the previously set one
chore: fix linter errors
8479240
chore: lockfile
0afa65b
chore: reformat with zed
a808ecc
chore: formatting
f2d7465
chore: reformatting with swiftlinter
eafa5fe
chore: instruct Claude
7632af9
chore: reduce linting errors
806c069
chore: line length violations
4ad1c3a
@claude
fix: resolve OSLog string concatenation build errors
56cf9c7 
Replace string concatenation with multiline literals in logger calls
to fix compilation errors and comply with SwiftLint line length rules.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@claude
fix: resolve all swiftlint violations and refactor codebase
71bd710 
This comprehensive refactoring addresses all critical swiftlint violations
and significantly improves code quality and maintainability:

## Violations Fixed

### Closure Parameter Position (5 files) ✅
- Fixed closure parameters to be on same line as opening brace
- Updated in DropdownWindowManager, RecapsWindowManager, MicrophoneCapture+AudioEngine, LLMService

### Function Body Length (6 files) ✅
- ProcessTap.swift: Extracted helper methods (createTapDescription, createProcessTap, createAggregateDevice)
- AudioRecordingCoordinator.swift: Extracted startSystemAudioRecording, startMicrophoneRecording, getTapStreamDescription
- GlobalShortcutManager.swift: Replaced switch with dictionary lookup
- SummaryView.swift: Extracted stateHeader, actionSection, stateWarningMessage, button computed properties
- AlertToast.swift: Extracted view mode methods and handleTapGesture

### Cyclomatic Complexity (3 occurrences) ✅
- GlobalShortcutManager.getKeyString: Reduced from 57 to 1 using dictionary
- GlobalShortcutSettingsView.getKeyString: Replaced with dictionary lookup
- GlobalShortcutSettingsView.getKeyCodeFromKeyEquivalent: Simplified with dictionary + small switch

### Type Body Length (5 files) ✅
- UserPreferencesRepository: 345→176 lines (extracted performUpdate helper, consolidated update methods)
- ProcessingCoordinator: Extracted processSummarizationIfEnabled, saveTranscriptionResults
- GeneralSettingsViewModel: Extracted validation and model update methods
- GeneralSettingsView: Reduced by extracting preview mocks
- SummaryView: Extracted helper methods and computed properties

### File Length (3 files) ✅
- AlertToast.swift: 775→425 lines (45% reduction)
  - Created AnimatedCheckmark.swift
  - Created AlertToast+Modifiers.swift
  - Created AlertToastTypes.swift
  - Created View+Toast.swift
- GeneralSettingsView.swift: 444→332 lines
  - Created GeneralSettingsView+Preview.swift
- GeneralSettingsViewModelSpec.swift: Minor test file cleanup

## Files Created
- Recap/Frameworks/Toast/AnimatedCheckmark.swift
- Recap/Frameworks/Toast/AlertToast+Modifiers.swift
- Recap/Frameworks/Toast/AlertToastTypes.swift
- Recap/Frameworks/Toast/View+Toast.swift
- Recap/UseCases/Settings/Components/TabViews/GeneralSettingsView+Preview.swift

## Build Status
✅ All files compile successfully
✅ No swiftlint errors remaining
⚠️ 8 minor warnings remain (file/type length just above thresholds)

## Key Improvements
- Better code organization with logical method extraction
- Reduced complexity using dictionaries instead of large switch statements
- Improved reusability with extracted helpers (e.g., performUpdate())
- Better separation of concerns with extracted preview mocks
- Maintained functionality while improving maintainability

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
fix(release0: clear debug macros
6b49a7e
fix: unit tests
f96d3a4
wip: drag and drop
fe318b8
feat: button to test the openai and openrouter providers
517020b
fix: keep the drag and drop panel open on drag
e5e55a8
feat: apply the same formatting as recording transcripts
fe25b70
fix(unit-tests): missing mocks
04f31e7
@nilleb
Merge pull request #1 from nillebco/feat/drag-and-drop
a6ee10d 
feat: drag and drop and test the configured LLM
@nilleb nilleb changed the title features: define a custom folder for the summaries and transcriptions, pretty formatting for the markdown export, use openai compatible endpoints, CLI to build and run the project locally, features: define a custom folder for the summaries and transcriptions, pretty formatting for the markdown export, use openai compatible endpoints, CLI to build and run the project locally, ... Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nilleb @GitWither @wobondar