Skip to content

Conversation

@madmiraal
Copy link
Contributor

Currently, when building on macOS 15 with Clang 17, we are getting the following warnings, which we treat as errors:

  In file included from modules/bullet/bullet_physics_server.cpp:7:
  In file included from modules/bullet/bullet_physics_server.h:10:
  In file included from modules/bullet/area_bullet.h:10:
  In file included from modules/bullet/collision_object_bullet.h:16:
  In file included from thirdparty/bullet/LinearMath/btTransform.h:18:
  In file included from thirdparty/bullet/LinearMath/btMatrix3x3.h:18:
  thirdparty/bullet/LinearMath/btVector3.h:1096:2: error: definition of implicit copy constructor for 'btVector4' is deprecated because it has a user-provided copy assignment operator [-Werror,-Wdeprecated-copy-with-user-provided-copy]
   1096 |         operator=(const btVector4& v)
        |         ^
  thirdparty/bullet/LinearMath/btVector3.h:1106:10: note: in implicit copy constructor for 'btVector4' first required here
   1106 |                 return btVector4(_mm_and_ps(mVec128, btvAbsfMask));
        |                        ^
  In file included from modules/bullet/bullet_physics_server.cpp:7:
  In file included from modules/bullet/bullet_physics_server.h:10:
  In file included from modules/bullet/area_bullet.h:13:
  In file included from modules/bullet/space_bullet.h:12:
  In file included from modules/bullet/result_callbacks.h:13:
  In file included from thirdparty/bullet/btBulletDynamicsCommon.h:27:
  In file included from thirdparty/bullet/BulletDynamics/ConstraintSolver/btPoint2PointConstraint.h:21:
  In file included from thirdparty/bullet/BulletDynamics/ConstraintSolver/btTypedConstraint.h:20:
  In file included from thirdparty/bullet/BulletDynamics/ConstraintSolver/btSolverConstraint.h:26:
  thirdparty/bullet/BulletDynamics/ConstraintSolver/btSolverBody.h:59:20: error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]
     59 |         SIMD_FORCE_INLINE const __m128 get128() const
        |                           ^~~~~

This PR applies the fixes sent upstream:

- Create explicit copy constructor for btVector4
- Create single const get128() method in btSimdScalar
@madmiraal madmiraal added the PR Type: Bug Fix Your current game should now work as expected. label Nov 14, 2025
@DanielaOrtner DanielaOrtner self-requested a review November 22, 2025 15:11
@DanielaOrtner DanielaOrtner merged commit a062836 into RebelToolbox:main Nov 22, 2025
15 checks passed
@madmiraal madmiraal deleted the fix-macos-build-warnings branch November 24, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR Type: Bug Fix Your current game should now work as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants