chore: added Dockerfile's and minor changes to rustfmt.toml #251
Conversation
There was a problem hiding this comment.
For the Dockerfile's we should use cargo-chef
Here are some exmaples
https://github.com/paradigmxyz/reth/blob/main/Dockerfile
https://github.com/ethereum/trin/blob/master/docker/Dockerfile
|
Also conventional commits should be used https://www.conventionalcommits.org/en/v1.0.0/ https://gist.github.com/qoomon/5dfcdf8eec66a051ecd85625518cfd13 |
|
Any reason to prefer to chef? I don't have a strong preference to anything, just curious. |
It makes building the Dockerfile after changes a lot quicker https://github.com/LukeMathWalker/cargo-chef?tab=readme-ov-file#benefits-vs-limitations Do to how rust is, it is really hard to take advantage of DockerFile's native caching without it |
|
oh I just noticed you marked the PR as draft, I will wait to continue reviewing it |
|
It would be useful to have |
There is only one executable atm, no? why do we then need docker-compose? |
yes, I'll let you know as soon as its ready. |
ch4r10t33r
changed the title
.dockerignore
Outdated
| testing/ef_tests/ | ||
| target/ | ||
| *.data | ||
| *.tar.gz |
There was a problem hiding this comment.
| *.tar.gz | |
| *.tar.gz | |
new line
Dockerfile.cross
Outdated
| COPY ./dist/bin/$TARGETARCH/ream /usr/local/bin/ream | ||
|
|
||
| EXPOSE 8545 8546 | ||
| ENTRYPOINT ["/usr/local/bin/ream"] |
| WORKDIR /app | ||
|
|
||
| LABEL org.opencontainers.image.source=https://github.com/reamlabs/ream | ||
| LABEL org.opencontainers.image.description="Ream is a modular, open-source Ethereum beam chain client." |
There was a problem hiding this comment.
| LABEL org.opencontainers.image.description="Ream is a modular, open-source Ethereum beam chain client." | |
| LABEL org.opencontainers.image.description="Ream is a modular, open-source Ethereum Beam Chain client." |
Dockerfile.cross
Outdated
| # This image is meant to enable cross-architecture builds. | ||
| # It assumes the ream binary has already been | ||
| # compiled for `$TARGETPLATFORM` and moved to `./bin`. | ||
| FROM --platform=$TARGETPLATFORM ubuntu:22.04 |
There was a problem hiding this comment.
| FROM --platform=$TARGETPLATFORM ubuntu:22.04 | |
| FROM --platform=$TARGETPLATFORM ubuntu:24.04 |
KolbyML
changed the title
Added