Conversation
kspieks
approved these changes
Jun 21, 2021
Contributor
kspieks
left a comment
There was a problem hiding this comment.
Thanks for the PR! Changes look good
@mjohnson541 should be able to merge this :)
83701a9 to
76c7f05
Compare
76c7f05 to
359f453
Compare
Contributor
Author
|
rebased for hack-a-thon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autogenerated tree for SubstitutionS family. DB tests pass for first commit where we change the logic nodes and setup the reverse map. fails after the tree is generated, with the following error: