Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all part deux #32

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Add all part deux #32

merged 2 commits into from
Jul 17, 2019

Conversation

johnhaley81
Copy link
Contributor

An alternative PR to #22

Depends on #31

@coveralls
Copy link

Pull Request Test Coverage Report for Build 53

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.9%) to 87.417%

Files with Coverage Reduction New Missed Lines %
src/Future.bs.js 12 85.38%
Totals Coverage Status
Change from base Build 51: 0.9%
Covered Lines: 119
Relevant Lines: 133

💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 53

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.9%) to 87.417%

Files with Coverage Reduction New Missed Lines %
src/Future.bs.js 12 85.38%
Totals Coverage Status
Change from base Build 51: 0.9%
Covered Lines: 119
Relevant Lines: 133

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 53

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.9%) to 87.417%

Files with Coverage Reduction New Missed Lines %
src/Future.bs.js 12 85.38%
Totals Coverage Status
Change from base Build 51: 0.9%
Covered Lines: 119
Relevant Lines: 133

💛 - Coveralls

@sikanhe
Copy link

sikanhe commented Jul 4, 2019

Any reason why this hasn't been added?

@gilbert
Copy link
Member

gilbert commented Jul 9, 2019

I don't work with reasonml at the moment and haven't for a while. Does anyone want to become a maintainer?

@briangorman
Copy link
Collaborator

briangorman commented Jul 11, 2019

@gilbert I can help maintain this project

@gilbert
Copy link
Member

gilbert commented Jul 12, 2019

@briangorman Invite sent

@briangorman
Copy link
Collaborator

@gilbert I reached out to you on your gitter about how to best proceed! Thanks

@briangorman briangorman merged commit 28a649c into RationalJS:master Jul 17, 2019
@briangorman briangorman mentioned this pull request Dec 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants