Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run refmt on all files and replace |. with -> in docs and comments #30

Merged
merged 3 commits into from
Nov 30, 2018
Merged

Run refmt on all files and replace |. with -> in docs and comments #30

merged 3 commits into from
Nov 30, 2018

Conversation

johnhaley81
Copy link
Contributor

This fixes #28

@coveralls
Copy link

coveralls commented Nov 29, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 50

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.525%
Totals Coverage Status
Change from base Build 48: 0.0%
Covered Lines: 111
Relevant Lines: 125
💛 - Coveralls

@scull7
Copy link
Collaborator

scull7 commented Nov 29, 2018

:shipit: Looks good to me

@gilbert
Copy link
Member

gilbert commented Nov 30, 2018

There are quite a lot of ->() parenthesis. Are these actually necessary, or are they just precautions inserted by the refmt?

@johnhaley81
Copy link
Contributor Author

Good eyes @gilbert. Those aren't needed and I removed them.

@gilbert
Copy link
Member

gilbert commented Nov 30, 2018

Great, thank you!

@gilbert gilbert merged commit 649a569 into RationalJS:master Nov 30, 2018
@johnhaley81 johnhaley81 deleted the run-refmt branch January 30, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format code using latest standards
4 participants
@johnhaley81 @coveralls @scull7 @gilbert