Skip to content

Comments

fromPromise failure tests#13

Merged
gilbert merged 2 commits intoRationalJS:masterfrom
scull7:promise-failure-tests
Jun 10, 2018
Merged

fromPromise failure tests#13
gilbert merged 2 commits intoRationalJS:masterfrom
scull7:promise-failure-tests

Conversation

@scull7
Copy link
Collaborator

@scull7 scull7 commented Jun 10, 2018

I was attempting to re-create an error I was seeing in an upstream
module. Seems that all is well here.

I was attempting to re-create an error I was seeing in an upstream
module. Seems that all is well here.
@scull7 scull7 requested a review from gilbert June 10, 2018 21:03
@coveralls
Copy link

coveralls commented Jun 10, 2018

Pull Request Test Coverage Report for Build 17

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+6.3%) to 97.938%

Totals Coverage Status
Change from base Build 15: 6.3%
Covered Lines: 82
Relevant Lines: 83

💛 - Coveralls

@gilbert
Copy link
Member

gilbert commented Jun 10, 2018

Nice, thanks for the extra assurance.

@gilbert gilbert merged commit 600e980 into RationalJS:master Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants