Test coverage #12
Merged
Test coverage #12
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a test to cover an uncovered flatMapOk case. - Add test:only command to just run `ospec` - Add test:cover command to run coverage with human readable coverage output. - Change test to generate test coverage - add a coverage:report command and add it to the posttest. Coverage can be tracked with http://coveralls.io, The following tasks need to be completed: 1. [x] Install the [node-coveralls] package. 2. [ ] Set up the repository on http://coveralls.io 3. [ ] Add a `.coveralls.yml` file with the proper repo token. 4. [ ] Update the `coverage:report` command to the following ```json { "coverage:report": "nyc --reporter=text-lcov ospec | coveralls" } ``` [node-coveralls]: https://github.com/nickmerwin/node-coveralls#nyc
|
Awesome! Is this ready to merge? |
|
@gilbert Ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ospecCoverage can be tracked with http://coveralls.io, The following tasks
need to be completed:
.coveralls.ymlfile with the proper repo token.coverage:reportcommand to the following{ "coverage:report": "nyc --reporter=text-lcov ospec | coveralls" }