[GSSoC'26] fix: rename l1_lock dict to l1_cache to prevent variable overwrite#2015
Merged
dipexplorer merged 1 commit intoJun 17, 2026
Merged
Conversation
self.l1_lock was declared as a Dict but immediately overwritten with threading.RLock(), causing all dict operations (key lookup, assignment, deletion, length check) to crash with TypeError. Renamed the dict to self.l1_cache while keeping self.l1_lock as the RLock. Closes RatLoopz#2008
Contributor
Author
|
@RatLoopz PR ready for review. Changes:
Note: Issues #2009 and #2010 appear to be already fixed in the current codebase (no stack trace leak in reports.ts, no interactions/check route found). Testing:
Closes #2008 |
Contributor
|
🎉 Congratulations @vipul674! Your Pull Request "[GSSoC'26] fix: rename l1_lock dict to l1_cache to prevent variable overwrite" has been successfully merged by @dipexplorer. Thank you for your valuable contribution to SahiDawa! 🇮🇳 Follow us on LinkedIn: https://www.linkedin.com/company/ratloopz/ to get shoutout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛑 STOP: Assignment & File Scope Check
📋 PR Summary & Link
self.l1_lockdict toself.l1_cacheto prevent the variable from being overwritten bythreading.RLock(), which causedTypeErroron all dict operations.🏷️ PR Type
type: bug✅ Checklist
Closes #2008)mainand resolved any conflicts