Feat : Add "Clear All History" button with confirmation to history/page.tsx#2002
Open
hrx01-dev wants to merge 1 commit into
Conversation
Member
|
Hey @hrx01-dev 👋, u used translation keys like t("clear_all_button"), t("clear_confirm_message"), t("clear_cancel_button"), and t("clear_confirm_button") in the code, but u didn't add these keys to the actual translation files (e.g., apps/web/messages/en.json). Bcz of this, next-intl will fail to find the translations and will render the raw key names on the UI (like History.clear_all_button) instead of actual text. update this PR by adding the missing keys to apps/web/messages/en.json under the correct namespace. Once added, I'll be happy to approve and merge it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛑 STOP: Assignment & File Scope Check
Warning
PRs with unrelated files will not be reviewed and may be closed.
📋 PR Summary & Link
showClearConfirmationto true. This state variable then conditionally renders a dedicated div containing the "Are you sure?" message and confirmation buttons, rather than usingwindow.confirm().📸 Proof of Work (Screenshots / Logs)
Important
No Pull Request will be merged without proof of testing!
Please drag & drop your screenshots/GIFs here:
🏷️ PR Type
type: bugtype: featuretype: docstype: testingtype: securitytype: performancetype: designtype: refactortype: devopstype: accessibility✅ Checklist
Closes #123)mainand resolved any conflicts