fix(dhcp, hostapd): validate interface names and sanitize shell commands #1894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add proper escapeshellarg() escaping for all user inputs passed to shell commands - Fixed vulnerabilities in networking, client management, and provider modules - Ensures all network interface names, file paths, and command parameters are properly escaped - Addresses security issues found in code review of shell script execution patterns
…nt command injection
tulik
force-pushed
the
fix/command-injection-vulnerabilities
branch
from
e861284 to
5988d29
Compare
|
@tulik thanks for this PR. one item to note:
I'll carve out time to test the other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harden Shell Execution Against Command Injection
Overview
This patch series eliminates command-injection vectors in networking and configuration modules by escaping every shell argument with
escapeshellarg().Files Updated
ajax/networking/do_sys_reset.phpajax/networking/get_ip_summary.phpajax/networking/get_netcfg.phpincludes/configure_client.phpincludes/dhcp.phpincludes/get_clients.phpincludes/provider.phpincludes/hostapd.phpKey Fixes
Impact
Validation