Added support for theme folder

[olivercox]

If options.settings['theme'] is set by calling

"app.set('theme', __dirname + '/themes/' + storeConfig.ActiveTheme);"

then all templates will be loaded from the themes folder if they exist.
If they don't exist templates will be loaded as usual.

[RandomEtc]

I think the call to existsSync should be cached in production apps.

[olivercox]

Yes that makes sense. Not sure how to do this but will take a look.
Could the current view cache be used?

[olivercox]

Would something like this work for the current cache

var engine = options.settings['view engine'] || 'ejs'
  , desiredExt = '.' + engine
  , ext = extname(file) || desiredExt
  , key = [themeFilePath, file, ext].join('-');
//Check if the file has already been resolved in the theme folder to avoid io
if (options.cache && cache[key]) file = cache[key]; 
if (fs.existsSync(resolve(themeFilePath, basename(file)))) {
    cache[key] = resolve(themeFilePath, basename(file));
    file = resolve(themeFilePath, basename(file));
}

[RandomEtc]

This looks simple enough - can you add some tests maybe an example? Apologies up-front that the tests are a little bit of a rats' nest, feel free to start a separate file.

[bebraw]

+1

Any progress with this?

By the way as a workaround it would be awesome if relative paths worked. Seems to fail with good old ...