drenv: Install helm from github releases #2333
Conversation
raaizik
requested review from
ELENAGER
and removed request for
nirs and
raghavendra-talur
raaizik
force-pushed
the
ra-1623
branch
3 times, most recently
from
7a98b69 to
4586e63
Compare
Resolves RamenDR#1623 Signed-off-by: raaizik <[email protected]>
nirs
left a comment
nirs
left a comment
There was a problem hiding this comment.
Thanks!
Commented only on test/README.md, same changes apply to other file.
| [Velero Basic Install](https://velero.io/docs/v1.16/basic-install/) | ||
|
|
||
| 1. Install `helm` tool - on Fedora you can use: | ||
| 1. Install Helm (version ≥ 3.13 recommended). |
There was a problem hiding this comment.
We don't mention the version in the title
| ```bash | ||
| sudo dnf install -y helm | ||
| ``` | ||
| sudo dnf install helm |
There was a problem hiding this comment.
We don't need to provide 2 options, this makes maintenance harder, and introduce issues with people running older distros or other disros (e.g. apt based). Best remove this text.
| **Option 2: Using official Helm GitHub releases (for older Fedora or | ||
| outdated package versions)** | ||
|
|
||
| Check the latest release: [Helm's GitHub release page](https://github.com/helm/helm/releases) |
There was a problem hiding this comment.
No need to check latest release, just provide the command to run to install the latest version like we do with other tools.
| curl -L https://get.helm.sh/helm-${HELM_VERSION}-linux-amd64.tar.gz -o helm.tgz | ||
| tar -xzf helm.tgz | ||
| sudo mv linux-amd64/helm /usr/local/bin/helm | ||
| rm -rf linux-amd64 helm.tgz |
There was a problem hiding this comment.
For getting the latest version we can use jq. We also need proper flags to curl to ensure it fails on errors.
% curl -fsSL https://api.github.com/repos/helm/helm/releases/latest | jq -r .tag_name
v4.0.1
This introduce another dependency but anyone working with kubernetes and json needs jq so this is not an issue.
For downloading we also need proper curl flags (this should be fixed for other tools):
curl -fsSL https://get.helm.sh/helm-${HELM_VERSION}-linux-amd64.tar.gz -o helm.tgz
For extracting helm from the tarball we can use the same command used for velero:
tar xf helm.tgz --strip 1 linux-amd64/helm
For installing we need to use the install command (used for other tools):
sudo install helm /usr/local/bin
| Verify: | ||
|
|
||
| ```bash | ||
| helm version |
There was a problem hiding this comment.
We don't have this section for other tools, it is not needed.
We typically add a url to the release page for more info, see other tools.
|
|
||
| > ⚠️ If you’re on Fedora 37 or earlier, the `dnf` package may install Helm | ||
| > 3.11 or older, which is not supported by Ramen. Use the GitHub release | ||
| > method instead. |
There was a problem hiding this comment.
Not needed when we provide one option to install latest version. Also Fedora 37 is dead for so many years there is no point to mention it now.
2 participants
Resolves #1623