Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g2oTargets.cmake has incorrect directories for solver and types #604

Closed
atuldivekar opened this issue Sep 27, 2022 · 2 comments
Closed

g2oTargets.cmake has incorrect directories for solver and types #604

atuldivekar opened this issue Sep 27, 2022 · 2 comments
Labels

Comments

@atuldivekar
Copy link

g2o/build/CMakeFiles/Export/lib/cmake/g2o/g2oTargets.cmake
contains

set_target_properties(g2o::solver_eigen PROPERTIES
INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include/g2o/solver_eigen;${_IMPORT_PREFIX}/include"
INTERFACE_LINK_LIBRARIES "g2o::core"
)

although installed directory contains
/usr/local/include/g2o/solvers/eigen

Similar error for other solver_ directories

This prevents proper linking of other frameworks that use g2o , for example OpenVSLAM community CMake generation gives:

Imported target "g2o::solver_eigen" includes non-existent path

"/usr/local/include/g2o/solver_eigen"

Also:
g2o/build/CMakeFiles/Export/lib/lib/cmake/g2o/g2oTargets.cmake
contains

Create imported target g2o::types_sba
add_library(g2o::types_sba SHARED IMPORTED)

set_target_properties(g2o::types_sba PROPERTIES
INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
INTERFACE_LINK_LIBRARIES "g2o::core;g2o::types_slam3d"
)

while installed directory contains
/usr/local/include/g2o/types/slam2d
and others

RainerKuemmerle added a commit that referenced this issue Oct 22, 2022
RainerKuemmerle added a commit that referenced this issue Oct 22, 2022
RainerKuemmerle added a commit that referenced this issue Oct 22, 2022
* Fix target properties for solver_eigen
* Add target includes for types

see #604
Copy link

github-actions bot commented Jan 1, 2025

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 1, 2025
Copy link

This issue was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant