should use size_t instead of int?

[ioquatix]

https://github.com/RainerKuemmerle/g2o/blob/master/g2o/core/sparse_block_matrix.hpp#L216-L221

Proposed fix:

    size_t colM=i;
    const typename SparseBlockMatrix<MatrixFactorType>::SparseMatrixBlock *b=it->second;
    typename SparseBlockMatrix<MatrixType>::IntBlockMap::const_iterator rbt=_blockCols[it->first].begin();
    while(rbt!=_blockCols[it->first].end()){
      //int colA=it->first;
      size_t rowA=rbt->first;

assigning size_t to int truncates the value.

[ioquatix]

I'm not sure if this helps, but in my mind, explicit casting is a hack and not a real solution, except in very specific situations.

[ioquatix]

Any update on this?

[RainerKuemmerle]

Not so far. I guess, it's also kind of low priority or do I miss any other
issues (despite compiler warnings).

On Tue, Oct 28, 2014 at 2:16 AM, Samuel Williams [email protected]
wrote:

Any update on this?

—
Reply to this email directly or view it on GitHub
#36 (comment).

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.