Skip to content

Output validator #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 9, 2025
Merged

Output validator #435

merged 11 commits into from
Mar 9, 2025

Conversation

mzuenni
Copy link
Collaborator

@mzuenni mzuenni commented Mar 5, 2025

Closes #424 once merged into master.

@mzuenni mzuenni mentioned this pull request Mar 5, 2025
17 tasks
@mzuenni mzuenni marked this pull request as ready for review March 5, 2025 22:38
@mzuenni mzuenni requested a review from mpsijm March 5, 2025 22:38
@mzuenni
Copy link
Collaborator Author

mzuenni commented Mar 6, 2025

@mpsijm Can this be merged?

@mpsijm
Copy link
Collaborator

mpsijm commented Mar 6, 2025

I'd like to review and try it first, but didn't have the time yet 😅 Definitely this weekend, maybe earlier 🙂

Copy link
Collaborator

@mpsijm mpsijm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks kind of weird to still have "lists of output validators" around, but it is simply easier to have Problem.validators always return a list, so that's probably fine 😛

Some comments below:

@mpsijm mpsijm merged commit a0e91de into draft Mar 9, 2025
6 checks passed
@mpsijm mpsijm deleted the output_validator branch March 9, 2025 13:13
mpsijm added a commit that referenced this pull request Mar 9, 2025
* use output_validator

* upgraded tests

* updated skel

* fix symlink

* create output_validators dir

* changed class constants

* fix source_dir(s)

* copy symlinks

* export legacy

* [export] Fix typo in comment

---------

Co-authored-by: Maarten Sijm <[email protected]>
mpsijm added a commit that referenced this pull request Mar 9, 2025
* use output_validator

* upgraded tests

* updated skel

* fix symlink

* create output_validators dir

* changed class constants

* fix source_dir(s)

* copy symlinks

* export legacy

* [export] Fix typo in comment

---------

Co-authored-by: Maarten Sijm <[email protected]>
mpsijm added a commit that referenced this pull request Mar 9, 2025
* use output_validator

* upgraded tests

* updated skel

* fix symlink

* create output_validators dir

* changed class constants

* fix source_dir(s)

* copy symlinks

* export legacy

* [export] Fix typo in comment

---------

Co-authored-by: Maarten Sijm <[email protected]>
mpsijm added a commit that referenced this pull request Mar 17, 2025
* use output_validator

* upgraded tests

* updated skel

* fix symlink

* create output_validators dir

* changed class constants

* fix source_dir(s)

* copy symlinks

* export legacy

* [export] Fix typo in comment

---------

Co-authored-by: Maarten Sijm <[email protected]>
mpsijm added a commit that referenced this pull request Mar 17, 2025
* use output_validator

* upgraded tests

* updated skel

* fix symlink

* create output_validators dir

* changed class constants

* fix source_dir(s)

* copy symlinks

* export legacy

* [export] Fix typo in comment

---------

Co-authored-by: Maarten Sijm <[email protected]>
mpsijm added a commit that referenced this pull request Mar 30, 2025
* use output_validator

* upgraded tests

* updated skel

* fix symlink

* create output_validators dir

* changed class constants

* fix source_dir(s)

* copy symlinks

* export legacy

* [export] Fix typo in comment

---------

Co-authored-by: Maarten Sijm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants