Skip to content

Support singular output_validator/ for 2023-07-draft spec #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mpsijm opened this issue Feb 15, 2025 · 0 comments · May be fixed by #433
Closed

Support singular output_validator/ for 2023-07-draft spec #424

mpsijm opened this issue Feb 15, 2025 · 0 comments · May be fixed by #433

Comments

@mpsijm
Copy link
Collaborator

mpsijm commented Feb 15, 2025

Follow-up of #421 (comment).

Currently (in the legacy and legacy-icpc specs), there can be multiple output_validators/. But according to the new spec (https://icpc.io/problem-package-format/spec/2023-07-draft.html#problem-package-structure-overview), there can be only one output validator, that lives in output_validator/. This makes sense, because if there are multiple output validators, this forces the problem packager to decide in which order these should be executed (using build and run scripts). We'd like to support this in BAPCtools as well, however:

See also the comments in problem.py and validate.py marked with # TODO #424, and DOMjudge/domjudge#2887.

@mpsijm mpsijm changed the title Support singular singular output_validator/ for 2023-07-draft spec Support singular output_validator/ for 2023-07-draft spec Feb 15, 2025
mpsijm added a commit to mpsijm/BAPCtools that referenced this issue Feb 15, 2025
mpsijm added a commit that referenced this issue Feb 15, 2025
* Implement 'type' field in problem.yaml from 2023-07-draft spec

* [problem] Move determining fields interactive, multipass, and custom_output to constructor of ProblemSettings

* Rename variables `multipass` to `multi_pass`

* [skel] Read type instead of validation

* [problem] Mark TODOs for #424 (support singular output_validator/)

* [skel] Remove support for `bt new_problem --type default` in favour of `pass-fail`

* [problem] If we don't find output validator paths, abort when problem type is interactive and/or multi-pass
This was referenced Mar 8, 2025
@mzuenni mzuenni closed this as completed Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants