Skip to content

Move replace out of scrollIntoView conditional #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move replace out of scrollIntoView conditional #6

wants to merge 1 commit into from

Conversation

@jtag05
Copy link

@jtag05 jtag05 commented Aug 31, 2022

This PR resolves and issue where content would not be replaced when scrollintoView is disabled and containerSelector is also used

This was referenced Aug 31, 2022
Open
Open
@h0lybyte
Copy link

Any word on when this pull request will be approved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lsimone lsimone lsimone approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtag05 @h0lybyte @lsimone