-
Notifications
You must be signed in to change notification settings - Fork 32
FHD-style beam decomposition #1641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1641 +/- ##
==========================================
- Coverage 99.93% 99.92% -0.01%
==========================================
Files 67 67
Lines 22682 22815 +133
==========================================
+ Hits 22668 22799 +131
- Misses 14 16 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| run_check_acceptability=True, | ||
| ): | ||
| """ | ||
| Convert E-field beam feed I response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing "to"
| """ | ||
| Convert E-field beam feed I response. | ||
| The feed I response is the the complex response of each instrumental |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The feed I response is the the complex response of each instrumental | |
| The feed I response is the complex response of each instrumental |
| Convert E-field beam feed I response. | ||
| The feed I response is the the complex response of each instrumental | ||
| feed to unpolarized emission (so it only has an feed index, no vector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| feed to unpolarized emission (so it only has an feed index, no vector | |
| feed to unpolarized emission (so it only has a feed index, no vector |
| component axis). The phase is related to time delays which can vary | ||
| spatially but do not differ between incident polarizations (so are | ||
| unpolarized). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get a mathematical definition, or link to a definition, here? "Related to time delays" is a little hard to understand :-D
|
@bhazelton can I perhaps suggest |
d3814a2 to
d608b33
Compare
Description
Add support for two new types of beams which are the two parts that FHD decomposes Jones matrices (E-field beams) into.
While these are needed by FHD, I suspect they might be more broadly useful to other simulators as well. I currently need them for pyFHD and it really makes the most sense to implement them on UVBeam because the decomposition needs to be done before interpolation.
The two new types of beams are:
This PR adds support for these two new kinds of beams to UVBeam, AnalyticBeam and BeamInterface objects.
To Do:
Note:
This PR is branched off of #1639, so it includes those updates and that PR should be merged first.
Motivation and Context
Types of changes
Checklist:
New feature checklist: