Skip to content

[bsp][nxp][imx] WIP: Add FRDM-i.MX91 bsp #10570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[bsp][nxp][imx] WIP: Add FRDM-i.MX91 bsp #10570

wants to merge 1 commit into from
+2,351 −0

Conversation

xusiwei
Copy link
Contributor

@xusiwei xusiwei commented Jul 31, 2025 •
edited
Loading

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

添加 NXP FRDM-i.MX91 开发板的 BSP

你的解决方案是什么 (what is your solution)

新增imx91目录

请提供验证的bsp和config (provide the config and bsp)

  • BSP: FRDM-i.MX91
  • .config:
  • action:

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@xusiwei xusiwei requested a review from Rbb666 as a code owner July 31, 2025 15:57
@github-actions github-actions bot added BSP: NXP Code related with NXP BSP labels Jul 31, 2025
@xusiwei xusiwei changed the title [bsp][nxp][imx] Add FRDM-i.MX91 bsp [bsp][nxp][imx] WIP: Add FRDM-i.MX91 bsp Jul 31, 2025
@BernardXiong
Copy link
Member

A核芯片，请启用MMU，外设都做ioremap，谢谢。

Rbb666
Rbb666 requested changes Aug 1, 2025
View reviewed changes
Copy link
Member

@Rbb666 Rbb666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请添加此BSP的CI看护

bsp/nxp/imx/imx91/applications/startup.c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

正确姿势不应该重写这个文件吧?

bsp/nxp/imx/imx91/applications/SConscript

group = DefineGroup('Applications', src, depend = [''], CPPPATH = CPPPATH)

list = os.listdir(cwd)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块多余的代码请删除

bsp/nxp/imx/imx91/applications/startup.c
return ;
}

int main(void)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main函数应该在 applications/main.c 中

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rbb666 Rbb666 Rbb666 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
BSP: NXP Code related with NXP BSP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xusiwei @BernardXiong @Rbb666