Skip to content

componnets: drivers: adc: remove build warnings and cppcheck error #10373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025

Conversation

unicornx
Copy link
Contributor

@unicornx unicornx commented Jun 9, 2025

这个 PR 包含了两个 commit, 建议 merge 时不要压缩,保持 2 个 commit:

  • "componnets: drivers: adc: remove build warnings" gcc 构建警告:
    components/drivers/misc/adc.c

    cast from pointer to integer of different size [-Wpointer-to-int-cast]

原因是在 components/drivers/misc/adc.c 中存在如下代码:

static rt_err_t _adc_control(rt_device_t dev, int cmd, void *args)
{
    ......
    if (cmd == RT_ADC_CMD_ENABLE && adc->ops->enabled)
    {
        result = adc->ops->enabled(adc, (rt_uint32_t)args, RT_TRUE);
    }
    else if (cmd == RT_ADC_CMD_DISABLE && adc->ops->enabled)
    {
        result = adc->ops->enabled(adc, (rt_uint32_t)args, RT_FALSE);
    }

对于 rt_adc_ops.enabled,第二个参数的类型为 rt_int8_t,这里将 args 强转为错误的类型。

解决方法,先将其转换为 rt_base_t(保持宽度和指针一致,不加这个依然会告警),然后再强制转换为 rt_int8_t,以消除构建警告。

  • "components: drivers: adc: fixed cppcheck error“ :在提交了上一个 fix warning 的 PR 后,cppcheck 继续报错:
[cpp_check.py 80 INFO] components/drivers/misc/adc.c:76:12: error: Uninitialized variable: result [legacyUninitvar]
    return result;
           ^

所以继续修改。

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

gcc build warnings:
cast from pointer to integer of different size [-Wpointer-to-int-cast]

For rt_adc_ops.enabled, the type of second param is rt_int8_t,
original _adc_control also called with wrong type casting.

Convert first to rt_base_t, then cast to rt_int8_t to remove the
build warnings.

Signed-off-by: Chen Wang <[email protected]>
[cpp_check.py 80 INFO] components/drivers/misc/adc.c:76:12:
error: Uninitialized variable: result [legacyUninitvar]
    return result;
           ^

Signed-off-by: Chen Wang <[email protected]>
@unicornx unicornx changed the title componnets: drivers: adc: remove build warnings componnets: drivers: adc: remove build warnings and cppcheck error Jun 9, 2025
@Rbb666 Rbb666 merged commit 60c6fc0 into RT-Thread:master Jun 10, 2025
58 checks passed
@unicornx unicornx deleted the dev-warning-adc branch June 10, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants