Skip to content

修复任务丢失,性能优化 #10355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

htl5241
Copy link
Contributor

@htl5241 htl5241 commented Jun 3, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added Kernel PR has src relate code tools labels Jun 3, 2025
@htl5241
Copy link
Contributor Author

htl5241 commented Jun 3, 2025

test.zip
任务丢失测试代码

@htl5241
Copy link
Contributor Author

htl5241 commented Jun 3, 2025

这个代码因为修改幅度比较大,所以整个文件做了格式化操作。还有已经过了测试,稳定性没问题。

@htl5241
Copy link
Contributor Author

htl5241 commented Jun 3, 2025

因为调度代码被执行的比较频繁,所以做了性能优化,cortex-m4在100mhz 下性能最低提升15%

@htl5241
Copy link
Contributor Author

htl5241 commented Jun 3, 2025

你们可以先跑这个文件的稳定性,完全没问题在拉入。我已经测试了10多天了。

@supperthomas
Copy link
Member

supperthomas commented Jun 3, 2025

不同的PR,可以用不同的分支名称,不需要放到一起。
新的PR开始之前,先基于origin/master上进行创建修改分支。

@Rbb666
Copy link
Member

Rbb666 commented Jun 3, 2025

CI有编译报错,请先解决下:

image

代码可以用:formatting 脚本格式化下


to_thread = _scheduler_get_highest_priority_thread(&highest_ready_priority);
_scheduler_update_highest_priority();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为什么需要先更新最高优先级的任务?什么情况下,需要手动更新这个?

@htl5241
Copy link
Contributor Author

htl5241 commented Jun 3, 2025

CI有编译报错,请先解决下:

image

代码可以用:formatting 脚本格式化下

ok

@htl5241
Copy link
Contributor Author

htl5241 commented Jun 3, 2025

CI有编译报错,请先解决下:

image

代码可以用:formatting 脚本格式化下

我测试了famatting 和clang-format效果一样

@htl5241 htl5241 requested a review from Guozhanxin June 5, 2025 12:04
Copy link

📌 Code Review Assignment

🏷️ Tag: kernel

Path: src
Reviewers: @GorrayLi

Changed Files (Click to expand)
  • src/scheduler_up.c

📊 Current Review Status (Last Updated: 2025-06-10 09:34 UTC)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kernel PR has src relate code tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants