Skip to content

Conversation

engdyn
Copy link
Contributor

@engdyn engdyn commented Oct 15, 2025

Qt 6.10 now requires find_package() for private modules. This fixes #17570

@Megamouse Megamouse added the Build and CI Anything related to the build process and continuous integration label Oct 15, 2025
@Megamouse Megamouse requested a review from hcorion October 15, 2025 18:28
@regularhunter
Copy link

regularhunter commented Oct 15, 2025

Using your proposed patch I still get build fails on openSUSE Tumbleweed. The following patch successfully compiles for me (though that doesn't mean it is correct).

diff --git a/3rdparty/qt6.cmake b/3rdparty/qt6.cmake
index ef89bda..bda135a 100644
--- a/3rdparty/qt6.cmake
+++ b/3rdparty/qt6.cmake
@@ -6,12 +6,12 @@ find_package(Qt6 ${QT_MIN_VER} CONFIG COMPONENTS Widgets Concurrent Multimedia M
 if(WIN32)
 	target_link_libraries(3rdparty_qt6 INTERFACE Qt6::Widgets Qt6::Concurrent Qt6::Multimedia Qt6::MultimediaWidgets Qt6::Svg Qt6::SvgWidgets)
 else()
-	find_package(Qt6 ${QT_MIN_VER} COMPONENTS DBus Gui)
+	find_package(Qt6 ${QT_MIN_VER} COMPONENTS DBus GuiPrivate)
 	if(Qt6DBus_FOUND)
-		target_link_libraries(3rdparty_qt6 INTERFACE Qt6::Widgets Qt6::DBus Qt6::Concurrent Qt6::Multimedia Qt6::MultimediaWidgets Qt6::Svg Qt6::SvgWidgets)
+		target_link_libraries(3rdparty_qt6 INTERFACE Qt6::Widgets Qt6::DBus Qt6::Concurrent Qt6::GuiPrivate Qt6::Multimedia Qt6::MultimediaWidgets Qt6::Svg Qt6::SvgWidgets)
 		target_compile_definitions(3rdparty_qt6 INTERFACE -DHAVE_QTDBUS)
 	else()
-		target_link_libraries(3rdparty_qt6 INTERFACE Qt6::Widgets Qt6::Concurrent Qt6::Multimedia Qt6::MultimediaWidgets Qt6::Svg Qt6::SvgWidgets)
+		target_link_libraries(3rdparty_qt6 INTERFACE Qt6::Widgets Qt6::Concurrent Qt6::GuiPrivate Qt6::Multimedia Qt6::MultimediaWidgets Qt6::Svg Qt6::SvgWidgets)
 	endif()
 	target_include_directories(3rdparty_qt6 INTERFACE ${Qt6Gui_PRIVATE_INCLUDE_DIRS})
 endif()

@engdyn
Copy link
Contributor Author

engdyn commented Oct 16, 2025

I installed openSUSE Tumbleweed in a VM and had no issues compiling it with my changes. What's the error you're encountering? @regularhunter

@regularhunter
Copy link

I installed openSUSE Tumbleweed in a VM and had no issues compiling it with my changes. What's the error you're encountering? @regularhunter

Second attempt built fine on OBS. I recreated the test OBS repo from my first attempt after deleting it, there must have had a typo or something in the patch file. I have attached the build log.

_log.txt

@AniLeo AniLeo merged commit 038ee09 into RPCS3:master Oct 21, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build and CI Anything related to the build process and continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to build with Qt 6.10

5 participants