Windows clang -- proof-of-concept #17579

qurious-pixel · 2025-10-13T15:41:42Z

Built with PRs from:

Todo:
silence warning for:

asmjit [ -Wdeprecated-anon-enum-enum-conversion ]
yaml-cpp [ -Wignored-attributes ]
libusb [ -Wunused-value ]
cubeb [ -Wdeprecated-declarations ]
Remove workaround for AVX512 with Windows Clang-Cl

EDIT: With VCPKG cache, clang-cl build completes in ~14mins. Without cache, ~3 hours.

ffmpeg Update rpcs3.yml Update rpcs3.yml Update rpcs3.yml folded scalar with neg newline x64-windows-release x64-windows-rel if: "!cancelled()" vcpkg_build_type Update rpcs3.yml no ccache ${{github.run_id}} zlib vcpkg qt vulkan ffmpeg llvm build with clang-cl Create build-windows-clang-cl.ps1 llvm --keep-going llvm[clang,core,tools,lld,target-x86]:x64-windows-release llvm:[email protected] llvm with debug on Create vcpkg.json Update rpcs3.yml ffmpeg features vcpkg nuget minimal vcpkg.json Update rpcs3.yml fetch nuget more packages vcpkg.json libpng vcpkg classic cmake 3.29.0 Rename vcpkg.json to x_vcpkg.json Update rpcs3.yml Update rpcs3.yml llvm Update rpcs3.yml git llvm LLVM with cache Update rpcs3.yml Update rpcs3.yml build llvm LLVM_TARGETS_TO_BUILD="X86" llvm binary set path build rpcs3 DIA SDK Update rpcs3.yml Update rpcs3.yml Update rpcs3.yml fix conditionals fix conditionals set shell VCPKG env vars DIA SDK Update asm.hpp Update types.hpp Update aesni.cpp Update CMakeLists.txt Update ConfigureCompiler.cmake Update StrFmt.cpp Update CMakeLists.txt Update CMakeLists.txt Build with changes Update CMakeLists.txt D:\a\rpcs3\rpcs3\llvm D:\a\rpcs3\rpcs3\llvm llvm-* llvm-${{ matrix.llvmver }} clangpath llvm-* $llvmver $clangPath $clangPath include bin rm duplicate "add_compile_options" USE_SYSTEM_ZSTD USE_SYSTEM_ZSTD USE_SYSTEM_ZSTD USE_SYSTEM_ZSTD zstd Update CMakeLists.txt PkgConfig zstd zstd::zstd ALIAS PkgConfig::libzstd clang-cl only cache hit Update CMakeLists.txt cache-hit cache vcpkg/vcpkg.exe NOT USE_SYSTEM_ZSTD vcpkg_root revert zstd Update CMakeLists.txt Update CMakeLists.txt Update CMakeLists.txt /defaultlib:zstd_static.lib Remove else /defaultlib:zstd.lib Zstd ahared Nodefaultlib Create Findzstd.cmake zstd CMakeLists.txt not use zstd system CMakeLists.txt dont add 3rdparty::libzstd add_library(PkgConfig::libzstd ALIAS 3rdparty::zstd) add_library(PkgConfig::libzstd ALIAS 3rdparty::zstd) add_library(3rdparty::libzstd ALIAS PkgConfig::zstd) add_library(3rdparty::zstd ALIAS PkgConfig::zstd) Update Findzstd.cmake zstd::zstd Update CMakeLists.txt zstd::zstd zstd::zstd CMakeLists.txt PkgConfig::libzstd CMakeLists.txt zstd::libzstd Update CMakeLists.txt Update CMakeLists.txt vcpkg zstd CMakeLists.txt MODULES CMakeLists.txt zstd::libzstd add_library(3rdparty::7zip ALIAS 3rdparty_7zip) LLVM Static-link on set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Release>:Release>") set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded") Update CMakeLists.txt message(STATUS "MSVC Runtime Library: ${CMAKE_MSVC_RUNTIME_LIBRARY}") revert CMakeLists.txt DCMAKE_MSVC_RUNTIME_LIBRARY="MultiThreaded" rpcs3_emu SHARED STATIC CMakeLists.txt cmake_policy(SET CMP0091 NEW) LLVM_AVAILABLE=ON add_compile_definitions(LLVM_AVAILABLE=true) add_compile_options(/MT) LLVM_AVAILABLE=1 add_compile_definitions(_DISABLE_STRING_ANNOTATION=1 _DISABLE_VECTOR_ANNOTATION=1) Update build-windows-clang-cl.ps1 clang msvc17-msvcrt rm compressed archve cachee name cache name again builtin clang-rt build all set $llvmPath extract into llvm copy with -verbose mv destination path build llvm cache $clangPath full build LLVM static LLVM -> LLVMCore STATIC_LINK_LLVM=OFF no lookup llvm bin dir revert revert revert LLVMCore -> LLVM LLVM -> LLVM-C llvm_map_components_to_libnames Update CMakeLists.txt LLVM CMakeLists.txt LLVM_DIR=$llvmPath MultiThreadedDLL CMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON clang-cl version cmake -v --log-level=VERBOSE built-in LLVM llvm lib folder PF short name built-in LLVM/Clang 20.1.8 mt.exe path Use llvm-mt "$clangPath/llvm-mt.exe" fix terminator Add winqtdeploy to PATH Test windeployqt6.exe with version Missing ) No winqtdeploy Build no quotes prep artifacts no winqtdeploy $VcpkgWindeployqt --version $($VcpkgWindeployqt) --version --version Invoke-Expression Update build-windows-clang-cl.ps1 rpcs3_win_clang.7z rpcs3 artifacts dir cp artifacts build/bin dir clone recent asmjit Update build-windows-clang-cl.ps1 CMAKE_CXX_SCAN_FOR_MODULES=ON default-openal USE_NATIVE_INSTRUCTIONS=ON Update ConfigureCompiler.cmake USE_NATIVE_INSTRUCTIONS=OFF / rm 512 instuctions revert set(LLVM_LIBS LLVM) COMPILER_X86 only add_compile_options(-msse -msse2 -mcx16 -mavx512f -mavx -mavx2 -maes -mrtm -mpclmul -mmwaitx -mwaitpkg) avx512 flags add_compile_options(-march=native) check_cxx_compiler_flag("-march=native" add_compile_options(-maes -mrtm -mpclmul -mmwaitx -mwaitpkg) COMMAND Qt6::windeployqt --version COMMAND Qt6::windeployqt $<TARGET_FILE:rpcs3> add vcpkg bin to PATH check vcpkg is added to PATH update PATH cache [System.EnvironmentVariableTarget]::Machine display all paths cmd.exe /c "echo %PATH%" make windeployqt verbose verbose 2 Invoke-Expression "cmd.exe /c "set PATH=%PATH%;$VcpkgBin"" Update build-windows-clang-cl.ps1 no invoke cmd.exe /c "set PATH=$VcpkgBin;%PATH%" --ignore-library-errors -DQTPATH_EXE="$VcpkgQtpath" no --ignore-library-errors Update CMakeLists.txt Update CMakeLists.txt Update CMakeLists.txt Update CMakeLists.txt Update CMakeLists.txt Update CMakeLists.txt Update CMakeLists.txt Update CMakeLists.txt change \ to / ${WINDEPLOYQT_EXECUTABLE} Qt6::windeployqt gci vcpkg tools bin --ignore-library-errors x64-windows/tools VCPKG_TRIPLET: x64-windows Save vcpkg cache revert revert remove MSVC runtime message revert rm dupes revert Delete buildfiles/cmake/Findzstd.cmake WINDEPLOYQT_EXECUTABLE Delete x_vcpkg.json add AVX512 compile options Wno-deprecated-anon-enum-enum-conversion clean-up silence warnings terminate properly set PRIVATE CFLAGS --no-vulkan rm vulkan lib at package step override cflags remove OpenGL_GL_PREFERENCE=LEGACY rm --no-vulkan switch Update CMakeLists.txt restore LLVM dir ASMJIT_CMAKE_FLAGS revert order check_cxx_compiler_flag Wno-unused-value revert revert Update CMakeLists.txt Update llvm_build_clang_cl.vcxproj Update llvm_build_clang_cl.vcxproj Update rpcs3.yml go to deploy if successful Create deploy-windows-clang-cl.sh build then deploy Update build-windows-clang-cl.ps1 deploy step test Update ProgramStateCache.cpp remove AVX512 Update JITLLVM.cpp FFMPEG 8.0 FFMPEG 8.0 LLVM 21 LLVM 21 set CMAKE_MSVC_RUNTIME_LIBRARY update OpenAL msys2 clang git openal-soft reset update yaml reset to master reset to master "Build succeeded" ALSOFT_ENABLE_MODULES OFF Build All Jobs Run Builds when not on Main branch Win Qt 6.9.3 Update build-mac-arm64.sh Update build-mac.sh Create TCDarwinX86_64.cmake

.ci/build-windows-clang.sh

.ci/build-windows-clang-cl.ps1

.github/workflows/rpcs3.yml

3rdparty/zstd/CMakeLists.txt

rpcs3/Emu/CMakeLists.txt

Megamouse · 2025-10-14T18:17:35Z

rpcs3/Emu/RSX/Program/ProgramStateCache.cpp


-#ifdef _MSC_VER
+//#ifdef _MSC_VER
+#if defined(_MSC_VER) && !defined(__clang__)


why are the changes in this file needed

Work around for runtime failing to detect AVX512 cpu missing. Task # 5.

Megamouse · 2025-10-14T18:20:39Z

buildfiles/cmake/ConfigureCompiler.cmake

+		check_cxx_compiler_flag("-msse -msse2 -mcx16" COMPILER_X86)
+		check_cxx_compiler_flag("-march=native" COMPILER_SUPPORTS_MARCH_NATIVE)
+		if (COMPILER_X86)
+			#add_compile_options(-msse -msse2 -mcx16 -mavx512f -mavx512vbmi -mavx512vl -mavx512dq -mavx512vpopcntdq -mavx -mavx2 -maes -mrtm -mpclmul -mmwaitx -mwaitpkg)


why is half of this commented?

To revert work around from ProgramStateCache.

hcorion · 2025-10-14T20:24:43Z

Please write the script in shell script instead of Powershell.

Megamouse · 2025-10-14T20:52:25Z

Please write the script in shell script instead of Powershell.

There was a GitHub runner issue with the env if you use a shell script.
That's why I wrote it in Powershell.
I believe it was something with shell running in a separate instance

hcorion · 2025-10-14T21:06:52Z

All our other Windows builds use shell script, what makes this one not work? It makes it significantly more annoying to maintain if it's in a different language

.github/workflows/rpcs3.yml

Megamouse · 2025-10-14T21:23:14Z

.github/workflows/rpcs3.yml

+        if: ${{ matrix.compiler == 'clang-cl' }}
+        shell: pwsh
+        run: |
+          if (!(Test-Path -Path D:\a\rpcs3\rpcs3\llvm-${{ matrix.llvmver }}\)) {


Missing comment for this section

Megamouse · 2025-10-14T21:37:15Z

All our other Windows builds use shell script, what makes this one not work? It makes it significantly more annoying to maintain if it's in a different language

I believe it's related to the bat file, which doesn't work with a shell script

qurious-pixel · 2025-10-15T04:41:56Z

I don't think this is ready to merge as-is, since I am not the author of the respective PR's, but wanted to get feedback/reviews to move the work forward.

3rdparty/zstd/CMakeLists.txt

qurious-pixel added 3 commits October 13, 2025 08:30

Update deploy-mac.sh

d243055

Merge branch 'master' into windows-clang

47b938c

AniLeo requested a review from hcorion October 13, 2025 23:08

Megamouse reviewed Oct 14, 2025

View reviewed changes

.github/workflows/rpcs3.yml Outdated Show resolved Hide resolved

Megamouse reviewed Oct 14, 2025

View reviewed changes

.github/workflows/rpcs3.yml Outdated Show resolved Hide resolved

Megamouse reviewed Oct 14, 2025

View reviewed changes

qurious-pixel and others added 3 commits October 15, 2025 08:01

LLVM 19.1.7

fd2576f

Merge branch 'master' into windows-clang

2b35b80

Updated OpenAL to 9c50193

451d6e0

Megamouse marked this pull request as draft October 15, 2025 17:21

qurious-pixel added 3 commits October 15, 2025 11:58

Merge branch 'master' into windows-clang

4a009b1

Fix compile flags for MSVC and Clang in CMakeLists

8228ae6

Merge branch 'master' into windows-clang

97a1a50

Megamouse reviewed Oct 16, 2025

View reviewed changes

3rdparty/zstd/CMakeLists.txt Outdated Show resolved Hide resolved

Megamouse added OS: Windows Build and CI Anything related to the build process and continuous integration labels Oct 17, 2025

qurious-pixel and others added 2 commits October 17, 2025 06:05

Merge branch 'master' into windows-clang

42a8f7d

Windows build shell script

c902134

qurious-pixel force-pushed the windows-clang branch from 6a42a93 to c902134 Compare October 17, 2025 14:06

Fix shell for Windows sh script

1148253

qurious-pixel mentioned this pull request Oct 19, 2025

[OOPS] #17604

Closed

Uh oh!

Windows clang -- proof-of-concept #17579

Are you sure you want to change the base?

Windows clang -- proof-of-concept #17579

Conversation

qurious-pixel commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Megamouse Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

qurious-pixel Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Megamouse Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

qurious-pixel Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

hcorion commented Oct 14, 2025

Uh oh!

Megamouse commented Oct 14, 2025

Uh oh!

hcorion commented Oct 14, 2025

Uh oh!

Uh oh!

Uh oh!

Megamouse Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

Megamouse commented Oct 14, 2025

Uh oh!

qurious-pixel commented Oct 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

qurious-pixel commented Oct 13, 2025 •

edited

Loading

qurious-pixel Oct 15, 2025 •

edited

Loading