Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable autotuning level for triton test and disable fp8 dot tests #100

Open
wants to merge 5 commits into
base: rocm-jaxlib-v0.4.31-qa
Choose a base branch
from

Conversation

hsharsha
Copy link

No description provided.

@hsharsha hsharsha requested a review from i-chaochen February 7, 2025 12:51
::testing::Combine(::testing::Values(F16, F32, BF16,
::testing::Combine(::testing::Values(F16,
// F32, temporality disable F32 due to ErrorSpec
BF16,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d6d8535 I have disabled this due to triton backport is not done yet. wondering is it still need to disable?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, I do not see any reason why F32 should not be supported now.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsharsha could you have a try based on Zoran's backport, please?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the test fails with @zoranjovanovic-ns autoner enable commit
[ FAILED ] DotTestTestSuite/DotTest.IsTritonSupportedExecutesCorrectlyForDot/f32_dot, where GetParam() = (11, dot)

@hsharsha
Copy link
Author

hsharsha commented Feb 7, 2025

[ RUN      ] DotTestTestSuite/DotTest.IsTritonSupportedExecutesCorrectlyForDot/f32_dot
2025-02-07 14:58:39.560103: W ./xla/service/compiler.h:213] Ignoring the buffer assignment proto provided.
xla/service/gpu/fusions/triton/triton_support_legacy_test.cc:119: Failure
Value of: RunAndCompareNoHloPasses( std::move(ti.Module()), ErrorSpec{ primitive_util::IsF8Type(lhs_type) ? 1.0 : 2e-4, 2e-4})
  Actual: false (INTERNAL: Failed to launch ROCm kernel: triton_op with block dimensions: 256x1x1: HIP_ERROR_InvalidValue)Expected: true
[  FAILED  ] DotTestTestSuite/DotTest.IsTritonSupportedExecutesCorrectlyForDot/f32_dot, where GetParam() = (11, dot) (1045 ms)

@zoranjovanovic-ns
Copy link

I saw same error in some other tests too. Will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants