-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable autotuning level for triton test and disable fp8 dot tests #100
base: rocm-jaxlib-v0.4.31-qa
Are you sure you want to change the base?
Conversation
…nSupportedExecutesCorrectlyForDot
::testing::Combine(::testing::Values(F16, F32, BF16, | ||
::testing::Combine(::testing::Values(F16, | ||
// F32, temporality disable F32 due to ErrorSpec | ||
BF16, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d6d8535 I have disabled this due to triton backport is not done yet. wondering is it still need to disable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment, I do not see any reason why F32 should not be supported now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hsharsha could you have a try based on Zoran's backport, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the test fails with @zoranjovanovic-ns autoner enable commit
[ FAILED ] DotTestTestSuite/DotTest.IsTritonSupportedExecutesCorrectlyForDot/f32_dot, where GetParam() = (11, dot)
|
I saw same error in some other tests too. Will investigate. |
No description provided.