Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve chip info logic. #581

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Improve chip info logic. #581

wants to merge 9 commits into from

Conversation

xuchen-amd
Copy link
Contributor

This PR:

  • Purpose: centralize and unify the source of system/chip related information.
  • Added YAML file src/utils/mi_gpu_data.yaml to promote readability and scalability for future supports.
  • Added src/utils/mi_gpu_data.py for system/machine spec retrievals.
  • Removed unused data structures and functions.
  • Added debug messages and fixed formatting.
  • Passed local ctest.

WIP:

  • Instantiate MIGPU singleton for the current system for easy references.
  • Display graphic information of the system by visualize the MIGPU singleton using Dash.

@xuchen-amd xuchen-amd marked this pull request as draft February 25, 2025 20:34
@xuchen-amd xuchen-amd marked this pull request as ready for review February 26, 2025 20:06
feizheng10
feizheng10 reviewed Feb 27, 2025
View reviewed changes
src/utils/mi_gpu_data.py Outdated

def get_num_xcds(self):
return self.__num_xcds

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I suggested, regardless using or not, we need to define MemoryPartitionMode as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memory partition and chip ids for different env are preserved fields in the yaml file for scalability :)

feizheng10
feizheng10 reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@feizheng10 feizheng10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! The whole structure is much better than before!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feizheng10 feizheng10 feizheng10 left review comments

@koomie koomie Awaiting requested review from koomie koomie is a code owner

@coleramos425 coleramos425 Awaiting requested review from coleramos425 coleramos425 is a code owner

@dgaliffiAMD dgaliffiAMD Awaiting requested review from dgaliffiAMD dgaliffiAMD is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuchen-amd @feizheng10