fix crash for running rocprofv3 on mi100 #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and missing counter csv file
ywang103-amd
requested review from
koomie,
coleramos425,
feizheng10 and
dgaliffiAMD
as code owners
coleramos425
requested changes
Feb 10, 2025
ywang103-amd
changed the title
feizheng10
approved these changes
Feb 10, 2025
coleramos425
approved these changes
Feb 10, 2025
ywang103-amd
added a commit
that referenced
this pull request
Feb 10, 2025
This reverts commit 5ee37b3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed "-m" parameter for rocprofv3 when on mi100 and add mechanism to avoid crash when rocprofv3 does not generate counter csv file.