Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change normal_unit default to per_kernel #555

Merged
merged 7 commits into from
Feb 27, 2025
Merged

Change normal_unit default to per_kernel #555

merged 7 commits into from
Feb 27, 2025

Conversation

feizheng10
Copy link
Contributor

@feizheng10 feizheng10 commented Feb 6, 2025 •
edited
Loading

Per #90 suggested

@feizheng10 feizheng10 requested a review from sohaibnd February 6, 2025 02:42
coleramos425
coleramos425 approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@coleramos425 coleramos425 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a CHANGELOG adjustment? Did we settle on if we modify the CHANGELOG in PRs or immediately before release?

@feizheng10
Copy link
Contributor Author

Does this need a CHANGELOG adjustment? Did we settle on if we modify the CHANGELOG in PRs or immediately before release?

Yes, this needs CHANGELOG in PR.
I intend to hold this before 6.4 release branching. What do you think?

@feizheng10 feizheng10 requested a review from a team as a code owner February 13, 2025 17:53
@coleramos425
Copy link
Collaborator

coleramos425 commented Feb 13, 2025 •
edited
Loading

Works for me. Looks like we need to fix some failing tests first

@feizheng10 feizheng10 merged commit 6ece52f into ROCm:develop Feb 27, 2025
12 checks passed
@feizheng10 feizheng10 deleted the default_to_per_kernel branch February 27, 2025 19:46
@sohaibnd sohaibnd mentioned this pull request Feb 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coleramos425 coleramos425 coleramos425 approved these changes

@sohaibnd sohaibnd sohaibnd approved these changes

@dgaliffiAMD dgaliffiAMD Awaiting requested review from dgaliffiAMD dgaliffiAMD is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feizheng10 @coleramos425 @sohaibnd