-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone binary #546
Merged
vedithal-amd
merged 10 commits into
ROCm:develop
from
vedithal-amd:vedithal/standalone-binary
Feb 20, 2025
Merged
Standalone binary #546
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7e27df2
Standalone binary
vedithal-amd 2d613d1
Add conditional test fixture for standalone binary
vedithal-amd 6461b25
create standalone binary using public rhel8
vedithal-amd aae44ee
Move docker files fromm utils to docker folder; Add standalone binary…
vedithal-amd cba8d03
fix formatting
vedithal-amd 9282db4
Organize docker files
vedithal-amd ab463a9
Add CHANGELOG statement; Remove requirements-standalonebinary.txt
vedithal-amd 15bf4c4
Fix standalone binary tests
vedithal-amd 4729530
fix formatting
vedithal-amd 90f0952
fix formatting
vedithal-amd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
FROM redhat/ubi8:8.10-1184 | ||
|
||
WORKDIR /app | ||
|
||
RUN yum install -y curl gcc cmake | ||
|
||
RUN yum install -y python38 python38-devel && \ | ||
yum clean all && \ | ||
rm -rf /var/cache/yum && \ | ||
curl -sS https://bootstrap.pypa.io/get-pip.py -o get-pip.py && \ | ||
python3.8 get-pip.py | ||
|
||
CMD ["/bin/bash", "-c", "\ | ||
python3.8 -m pip install -r requirements.txt \ | ||
&& python3.8 -m pip install nuitka patchelf \ | ||
&& rm -rf build \ | ||
&& cmake -B build -S . \ | ||
&& make -C build standalonebinary \ | ||
"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
services: | ||
standalone: | ||
build: | ||
context: ../ | ||
dockerfile: docker/Dockerfile.standalone | ||
devices: | ||
- /dev/kfd | ||
- /dev/dri | ||
security_opt: | ||
- seccomp:unconfined | ||
volumes: | ||
- ../:/app |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
services: | ||
test: | ||
build: | ||
context: ../ | ||
dockerfile: docker/Dockerfile.test | ||
devices: | ||
- /dev/kfd | ||
- /dev/dri | ||
security_opt: | ||
- seccomp:unconfined | ||
volumes: | ||
- ../:/app |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import pytest | ||
|
||
|
||
def pytest_addoption(parser): | ||
parser.addoption( | ||
"--call-binary", | ||
action="store_true", | ||
default=False, | ||
help="Call standalone binary instead of main function during tests", | ||
) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to add comments: this doesn't work on WIN.