Escape the __args.remaining before joining together #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HollowMan6
requested review from
coleramos425,
feizheng10 and
dgaliffiAMD
as code owners
Signed-off-by: Daniel Su <[email protected]>
* Update name and icon for browser tab to rocprofiler-compute. Signed-off-by: xuchen-amd <[email protected]> * Update name and icon for browser tab to rocprofiler-compute. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
* find/replace Omniperf to ROCm Compute Profiler Signed-off-by: Peter Park <[email protected]> * update name in Sphinx conf Signed-off-by: Peter Park <[email protected]> * mv what-is-omniperf.rst -> what-is-rocprof-compute.rst Signed-off-by: Peter Park <[email protected]> * update Tutorials section Signed-off-by: Peter Park <[email protected]> * add Omniperf as keyword to Conceptual section for internal search Signed-off-by: Peter Park <[email protected]> * update Reference section Signed-off-by: Peter Park <[email protected]> * black fmt conf.py Signed-off-by: Peter Park <[email protected]> * update profile mode and basic usage subsections Signed-off-by: Peter Park <[email protected]> * update how to use analyze mode subsection Signed-off-by: Peter Park <[email protected]> * update install section Signed-off-by: Peter Park <[email protected]> * fix sphinx warnings Signed-off-by: Peter Park <[email protected]> * fix cmd line examples in profile/mode.rst Signed-off-by: Peter Park <[email protected]> * update install decision tree image Signed-off-by: Peter Park <[email protected]> * fix TOC and index Signed-off-by: Peter Park <[email protected]> fix weird wording * fix cli text: deriving rocprofiler-compute metrics... Signed-off-by: Peter Park <[email protected]> * update standalone-gui.rst Signed-off-by: Peter Park <[email protected]> * restore removed doc updates from ROCm#428 Signed-off-by: Peter Park <[email protected]> * update ref to Omniperf in index.rst Signed-off-by: Peter Park <[email protected]> * fix grafana connection name to match image Signed-off-by: Peter Park <[email protected]> * update cmds in tutorials Signed-off-by: Peter Park <[email protected]> --------- Signed-off-by: Peter Park <[email protected]>
* MI300 roofline enablement in rocprofiler-compute requirements.txt - running some modules complained about numpy version too new, adding extra requirement that numpy be 1.x pmc_roof_perf.txt - adding TCC_BUBBLE_sum counter to profile soc_gfx940.py soc_gfx941.py soc_gfx942.py - remove console logs reading that roofline is temporarily disabled, uncommenting blocks that check for roofline csv and run roofline post-processing roofline_calc.py - add mi300 to supported soc - add new calculation for hbm_data for MI300 using tcc_bubble_sum, checks if counter > 0 to use - add to a few comments roofline-ubuntu-20_04-mi300-rocm6 - binary for the ubuntu systems to enable mi300 roofline calculations from rocm-amdgpu-bench Note- other distros will get roofline bins to enable mi300, but need to be further tested before putting into branch. Signed-off-by: Carrie Fallows <[email protected]> * Reformatting roofline_calc.py Signed-off-by: Carrie Fallows <[email protected]> --------- Signed-off-by: Carrie Fallows <[email protected]>
* Add pre commit hook for Python formatting Signed-off-by: coleramos425 <[email protected]> * Update formatting workflow to run on latest Python and add isort formatter Signed-off-by: coleramos425 <[email protected]> * Fix caught yaml formatting issues * Update pyproject file * Add pre-commit hook instruction to CONTRIBUTING guide * Remove target-version from black pyproject.toml * Fixed formatting errors found with black and isort Signed-off-by: David Galiffi <[email protected]> * Run hook: Whitespaces, fix end of file spaces --------- Signed-off-by: coleramos425 <[email protected]> Signed-off-by: David Galiffi <[email protected]> Co-authored-by: David Galiffi <[email protected]>
|
FYI @feizheng10. If I remember correctly this PR overlaps with your MPI development branch. |
The current way ignores the case and won't work if the arguments include a space. Signed-off-by: Hollow Man <[email protected]>
HollowMan6
force-pushed
the
amd-staging
branch
from
8bcad71 to
6f4b585
Compare
vedithal-amd
force-pushed
the
amd-staging
branch
from
1b20ae9 to
272e5b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way ignores the case and won't work if the arguments include a space.