Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Spatial multiplexing: part2, analysis(merge to develop) (#542)
* External CI: rename pipeline to rocprofiler-compute (#463) Signed-off-by: Daniel Su <[email protected]> * Update webui branding (#459) * Update name and icon for browser tab to rocprofiler-compute. Signed-off-by: xuchen-amd <[email protected]> * Update name and icon for browser tab to rocprofiler-compute. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]> * Update branding in documentation (#442) * find/replace Omniperf to ROCm Compute Profiler Signed-off-by: Peter Park <[email protected]> * update name in Sphinx conf Signed-off-by: Peter Park <[email protected]> * mv what-is-omniperf.rst -> what-is-rocprof-compute.rst Signed-off-by: Peter Park <[email protected]> * update Tutorials section Signed-off-by: Peter Park <[email protected]> * add Omniperf as keyword to Conceptual section for internal search Signed-off-by: Peter Park <[email protected]> * update Reference section Signed-off-by: Peter Park <[email protected]> * black fmt conf.py Signed-off-by: Peter Park <[email protected]> * update profile mode and basic usage subsections Signed-off-by: Peter Park <[email protected]> * update how to use analyze mode subsection Signed-off-by: Peter Park <[email protected]> * update install section Signed-off-by: Peter Park <[email protected]> * fix sphinx warnings Signed-off-by: Peter Park <[email protected]> * fix cmd line examples in profile/mode.rst Signed-off-by: Peter Park <[email protected]> * update install decision tree image Signed-off-by: Peter Park <[email protected]> * fix TOC and index Signed-off-by: Peter Park <[email protected]> fix weird wording * fix cli text: deriving rocprofiler-compute metrics... Signed-off-by: Peter Park <[email protected]> * update standalone-gui.rst Signed-off-by: Peter Park <[email protected]> * restore removed doc updates from #428 Signed-off-by: Peter Park <[email protected]> * update ref to Omniperf in index.rst Signed-off-by: Peter Park <[email protected]> * fix grafana connection name to match image Signed-off-by: Peter Park <[email protected]> * update cmds in tutorials Signed-off-by: Peter Park <[email protected]> --------- Signed-off-by: Peter Park <[email protected]> * MI300 roofline enablement in rocprofiler-compute (#470) * MI300 roofline enablement in rocprofiler-compute requirements.txt - running some modules complained about numpy version too new, adding extra requirement that numpy be 1.x pmc_roof_perf.txt - adding TCC_BUBBLE_sum counter to profile soc_gfx940.py soc_gfx941.py soc_gfx942.py - remove console logs reading that roofline is temporarily disabled, uncommenting blocks that check for roofline csv and run roofline post-processing roofline_calc.py - add mi300 to supported soc - add new calculation for hbm_data for MI300 using tcc_bubble_sum, checks if counter > 0 to use - add to a few comments roofline-ubuntu-20_04-mi300-rocm6 - binary for the ubuntu systems to enable mi300 roofline calculations from rocm-amdgpu-bench Note- other distros will get roofline bins to enable mi300, but need to be further tested before putting into branch. Signed-off-by: Carrie Fallows <[email protected]> * Reformatting roofline_calc.py Signed-off-by: Carrie Fallows <[email protected]> --------- Signed-off-by: Carrie Fallows <[email protected]> * Update Python format checker (#471) * Add pre commit hook for Python formatting Signed-off-by: coleramos425 <[email protected]> * Update formatting workflow to run on latest Python and add isort formatter Signed-off-by: coleramos425 <[email protected]> * Fix caught yaml formatting issues * Update pyproject file * Add pre-commit hook instruction to CONTRIBUTING guide * Remove target-version from black pyproject.toml * Fixed formatting errors found with black and isort Signed-off-by: David Galiffi <[email protected]> * Run hook: Whitespaces, fix end of file spaces --------- Signed-off-by: coleramos425 <[email protected]> Signed-off-by: David Galiffi <[email protected]> Co-authored-by: David Galiffi <[email protected]> * Bump cryptography from 43.0.0 to 43.0.1 in /docs/sphinx (#473) Bumps [cryptography](https://github.com/pyca/cryptography) from 43.0.0 to 43.0.1. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@43.0.0...43.0.1) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix file permission on MI300 roofline binary (#477) Signed-off-by: David Galiffi <[email protected]> * Removing numpy requirements of <2 (#478) Checks are failing if version too high and no need for lower version Signed-off-by: Carrie Fallows <[email protected]> * Fix crash when loading web UI roofline for gfx942 (#479) * Fix crash when loading web UI roofline for gfx942 * Fix formatting Signed-off-by: benrichard-amd <[email protected]> * Make same changs for gfx940, gfx942. Signed-off-by: benrichard-amd <[email protected]> * Fix formatting in soc_gfx940 and soc_gfx941. Signed-off-by: benrichard-amd <[email protected]> --------- Signed-off-by: benrichard-amd <[email protected]> * Rebranding name change patch (#469) * Patch in missed name change for rebranding. Signed-off-by: xuchen-amd <[email protected]> * Patch in missed name change for rebranding. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]> * Move dependabot.yml to .github/ and bump rocm-docs-core (#481) * Move dependabot.yml to .github/ * Bump rocm-docs-core to 1.8.5 * Bump rocm-docs-core to 1.9.0 * Fix packaging for upgrading (#486) Specify that "rocprofiler-compute" replaces / obsoletes the "omniperf" package. * Renamed extension path from omniperf to rocprofiler_compute (#487) Signed-off-by: Tim Gu <[email protected]> * MI300 rhel and sles roofline binaries (#480) * Roofline bins for MI300 on rhel and sles distributions Built from rocm-amdgpu-bench, tested on respective distro systems with MI300 hardware. Signed-off-by: Carrie Fallows <[email protected]> * Minor modifications removing hardcoded variables in roofline files. Signed-off-by: Carrie Fallows <[email protected]> --------- Signed-off-by: Carrie Fallows <[email protected]> * Modify test_profile_general.py ctest to include MI300 enablement (#498) Signed-off-by: Carrie Fallows <[email protected]> * part 1 to support rocprofv3 (#492) * rocprofv3 support initial commit -Can run rocprofv3 but ultimately fails. rocprofv3 says the counter capacity is exceeded and the output CSV file format is different from v1/v2. * Add rocprofv3 detection so v2 can still be used It's hacky but it'll do for now. * Add code path to convert rocprofv3 JSON output into CSV * Grab correct value for Queue ID * Use _sum suffix to sum TCC counters Previously we were specifying each channel for TCC counters. rocprofv3 does not support specifing each TCC channel, and instead will auto sum given the TCC counter name. The counter name with the _sum suffix is also supported and is also supported in v1 and v2. So we will use the TCC counter name with the _sum suffix. * Fix incorrect counter outputs when using rocprofv3 In the JSON output some counters appear multime times and must be summed to get the correct value. These summed values match the rocprofv3 output in CSV mode and also match the rocprofv2 output. * Remove duplicate Correlation_ID and Wave_Size in output * Handle json output that does not contain any dispatches Omniperf was assuming each JSON output from rocprofv3 would always contain dispatches. This is not the case. For example, in a multi-process workload where one of the processes does not dispatch any kernels. A JSON file will still be output for this process but it will not contain any dispatches. * Code cleanup * Update search path for rocprofv3 results Rocprofv3 was updated to include the hostname in the path where it outputs results. * Handle accumulate counters In v1/v2 rocprof uses the SQ_ACCUM_PREV_HIRES counter for the accumualte counters. v3 does not have this. So we need to define our own counters in counter_defs.yaml. For this we use the counter name + _ACCUM, for example SQ_INSTR_LEVEL_SMEM_ACCUM. To use rocprofv3 you will need to update counter_defs.yaml to include these new counter definitions. * Use correct GPU ID When converting JSON -> CSV we were assigning node_id to GPU_ID. Since the JSON contains non-GPU devices, the node_id for GPUs might not start at 0 as expected. This commit maps the agent ID to the appropriate GPU ID. * Parse scratch memory per work item from JSON * Support rocprofv3 CSV parsing JSON decoding is very slow for large files. Include support for parsing rocprofv3 CSV output and make that the default. CSV/JSON can be toggled via the ROCPROF_OUTPUT_FORMAT environment variable e.g. ROCPROF_OUTPUT_FORMAT=csv or ROCPROF_OUTPUT_FORMAT=json * black format after merge * format isort * change return of rocprof_cmd to try to resolve test's error * hack to pick last part of rocminfo's name * debug log of hacks * Modify test_profile_general.py ctest to include MI300 enablement. Currently failing because of explicitly excluded roofline files for the soc and autofailed asserts for roof-only tests- originally in place because roofline was not enabled on mi300 yet. Signed-off-by: Carrie Fallows <[email protected]> * black and isort formated * corrected line of copyright --------- Signed-off-by: Carrie Fallows <[email protected]> Co-authored-by: benrichard-amd <[email protected]> Co-authored-by: YANG WANG <[email protected]> Co-authored-by: Carrie Fallows <[email protected]> * fix for crash of timestamp of part 1 for rocprofv3 (#499) * fix the error caused by ignoring the lack of counter csv file from rocprofv3 for timestamp * isort and black formated * quick fix for gfx906 roofline (#505) * Multi node support (#503) * [CTest] Pipeline failures for MI300 (#483) * Propagate new chip_id logic to testing workflow Signed-off-by: coleramos425 <[email protected]> * Add a debug line to tests Signed-off-by: coleramos425 <[email protected]> * Trying to set rocprofv2 generally in CTest module Signed-off-by: coleramos425 <[email protected]> * Remove temp debugging lines from CI Signed-off-by: coleramos425 <[email protected]> * Add roofline entry for MI300 expected files in CI tests Signed-off-by: coleramos425 <[email protected]> * Make num_devices modifier global in scope Signed-off-by: coleramos425 <[email protected]> * Change kernel name in PyTest to confirm rocprofv2 bug Related to https://ontrack-internal.amd.com/browse/SWDEV-503453 Signed-off-by: coleramos425 <[email protected]> --------- Signed-off-by: coleramos425 <[email protected]> * Spatial-multiplexing: part 1 profiling stage (#465) * rocprofv3 support initial commit -Can run rocprofv3 but ultimately fails. rocprofv3 says the counter capacity is exceeded and the output CSV file format is different from v1/v2. * Add rocprofv3 detection so v2 can still be used It's hacky but it'll do for now. * Add code path to convert rocprofv3 JSON output into CSV * Grab correct value for Queue ID * Use _sum suffix to sum TCC counters Previously we were specifying each channel for TCC counters. rocprofv3 does not support specifing each TCC channel, and instead will auto sum given the TCC counter name. The counter name with the _sum suffix is also supported and is also supported in v1 and v2. So we will use the TCC counter name with the _sum suffix. * Fix incorrect counter outputs when using rocprofv3 In the JSON output some counters appear multime times and must be summed to get the correct value. These summed values match the rocprofv3 output in CSV mode and also match the rocprofv2 output. * Remove duplicate Correlation_ID and Wave_Size in output * Handle json output that does not contain any dispatches Omniperf was assuming each JSON output from rocprofv3 would always contain dispatches. This is not the case. For example, in a multi-process workload where one of the processes does not dispatch any kernels. A JSON file will still be output for this process but it will not contain any dispatches. * Code cleanup * Update search path for rocprofv3 results Rocprofv3 was updated to include the hostname in the path where it outputs results. * Handle accumulate counters In v1/v2 rocprof uses the SQ_ACCUM_PREV_HIRES counter for the accumualte counters. v3 does not have this. So we need to define our own counters in counter_defs.yaml. For this we use the counter name + _ACCUM, for example SQ_INSTR_LEVEL_SMEM_ACCUM. To use rocprofv3 you will need to update counter_defs.yaml to include these new counter definitions. * debug code * add logic code for multiplexing * minor fix * more fixes * rocprofv3 support initial commit -Can run rocprofv3 but ultimately fails. rocprofv3 says the counter capacity is exceeded and the output CSV file format is different from v1/v2. * Add rocprofv3 detection so v2 can still be used It's hacky but it'll do for now. * Add code path to convert rocprofv3 JSON output into CSV * Grab correct value for Queue ID * Use _sum suffix to sum TCC counters Previously we were specifying each channel for TCC counters. rocprofv3 does not support specifing each TCC channel, and instead will auto sum given the TCC counter name. The counter name with the _sum suffix is also supported and is also supported in v1 and v2. So we will use the TCC counter name with the _sum suffix. * Fix incorrect counter outputs when using rocprofv3 In the JSON output some counters appear multime times and must be summed to get the correct value. These summed values match the rocprofv3 output in CSV mode and also match the rocprofv2 output. * Remove duplicate Correlation_ID and Wave_Size in output * Handle json output that does not contain any dispatches Omniperf was assuming each JSON output from rocprofv3 would always contain dispatches. This is not the case. For example, in a multi-process workload where one of the processes does not dispatch any kernels. A JSON file will still be output for this process but it will not contain any dispatches. * Code cleanup * Update search path for rocprofv3 results Rocprofv3 was updated to include the hostname in the path where it outputs results. * Handle accumulate counters In v1/v2 rocprof uses the SQ_ACCUM_PREV_HIRES counter for the accumualte counters. v3 does not have this. So we need to define our own counters in counter_defs.yaml. For this we use the counter name + _ACCUM, for example SQ_INSTR_LEVEL_SMEM_ACCUM. To use rocprofv3 you will need to update counter_defs.yaml to include these new counter definitions. * count accu files as well * Use correct GPU ID When converting JSON -> CSV we were assigning node_id to GPU_ID. Since the JSON contains non-GPU devices, the node_id for GPUs might not start at 0 as expected. This commit maps the agent ID to the appropriate GPU ID. * fix error with csv file parse from json and merge during post-processing * implemented parsing of csv files from v3 output for optimization * Parse scratch memory per work item from JSON * Support rocprofv3 CSV parsing JSON decoding is very slow for large files. Include support for parsing rocprofv3 CSV output and make that the default. CSV/JSON can be toggled via the ROCPROF_OUTPUT_FORMAT environment variable e.g. ROCPROF_OUTPUT_FORMAT=csv or ROCPROF_OUTPUT_FORMAT=json * black format after merge * format isort * change return of rocprof_cmd to try to resolve test's error * hack to pick last part of rocminfo's name * debug log of hacks * Modify test_profile_general.py ctest to include MI300 enablement. Currently failing because of explicitly excluded roofline files for the soc and autofailed asserts for roof-only tests- originally in place because roofline was not enabled on mi300 yet. Signed-off-by: Carrie Fallows <[email protected]> * black and isort formated * formated by isort and black * change default rocprof's output to csv * repaired crash caused by missing csv counter file when running for timestamp * change name to spatial-multiplexing from multiplexing * make necessary modification for review * set the value of spatial_multiplexing in argument defautly to None * repair the part that blocks regular pmc files' generation --------- Signed-off-by: Carrie Fallows <[email protected]> Co-authored-by: benrichard-amd <[email protected]> Co-authored-by: fei.zheng <[email protected]> Co-authored-by: YANG WANG <[email protected]> Co-authored-by: Carrie Fallows <[email protected]> * Simple fix for gpu model value. (#508) Signed-off-by: xuchen-amd <[email protected]> * Add FP64 to plot adhering to pdf name (#507) * Replacing FP32-only plot with an FP32&FP64 combo plot. Results will likely be negligible but the plot name indicates both should be graphed. Signed-off-by: Carrie Fallows <[email protected]> * Remove duplicate AI plot to clean up fp32 fp64 graph Signed-off-by: Carrie Fallows <[email protected]> --------- Signed-off-by: Carrie Fallows <[email protected]> * Add gpu series for roofline (#510) * Add gpu_series for roofline. * Use gpu_series in path names for roofline. * Fix TCC on MI200 when introduce rocprofv3 (#509) * quick fix for v2 * one more fix * revert a bit --------- Co-authored-by: ywang103-amd <[email protected]> * initial implementation of analyze part of spatial-multiplexing * Bump rocm-docs-core from 1.9.0 to 1.12.0 in /docs/sphinx (#511) Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.9.0 to 1.12.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.9.0...v1.12.0) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add exclusion for expired columns * block sanity check and set correct dir for sysinfo.csv * correct typo for fucntion merge_counters_spatial_multiplex and format the code * add call for csv merging for multiplex and modify of condition check * modify logic of create_df_pmc * Update sample roofline plot img (#516) * Modify path to use gpu_model instead of gpu_series to match other workload directory path creation/search points. Affects manual testing, does not seem to affect ctests. (#513) Signed-off-by: Carrie Fallows <[email protected]> * Improve formatting when displaying rocprof command. (#476) * Improve formatting when displaying rocprof command. Signed-off-by: xuchen-amd <[email protected]> * Fix python formatting. Signed-off-by: xuchen-amd <[email protected]> * Strip unwanted characters (rocprofv1 specific) from rocprof commands. Signed-off-by: xuchen-amd <[email protected]> * Strip unwanted characters (rocprofv1 specific) from rocprof commands. Signed-off-by: xuchen-amd <[email protected]> * Save the unmodified arguments for rocprof for debug message display. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]> * resolve issue related to multi-indexing(need to resolve metric calculation next step) * quick fix for mpi_support (#518) * Pass accumulate counters to rocprofv3 using -E option (#522) rocprofv3 has a new -E option where extra counters can be passed (see accum_counters.yaml) instead of defining them in counter_defs.yaml. * Unify all file handling with pathlib (#512) * Replace occurences of os.path functions with equivalent functions from pathlib library * Remove unwanted imports of os.path and os * Add coding guidelines for using pathlib instead of os.path * Auto sync staging and mainline on a weekly cadence (#517) Signed-off-by: coleramos425 <[email protected]> * Docker environment for testing (#515) * Add instructions on how to use Docker for manual and automatic testing * Quick fix for mpi_support (#527) * made change on the logic to add roofline file to expected csv list to fix crash on mi100 (#528) * fixed the content issue in counter columns and make analyze mode work * remove unnessaary log print * Use PAT to bypass branch protection * removed requirement for user to specify node info in argument of spatial_multiplexing and added comment on functions to merge dataframe * add log for setup_workload_dir to check failure * try to change way to know if in spatial multiplexing mode to try to resolve failure of unit test * remove unnecessary comment * add todo index to indicate fuure removal of format conversion --------- Signed-off-by: Daniel Su <[email protected]> Signed-off-by: xuchen-amd <[email protected]> Signed-off-by: Peter Park <[email protected]> Signed-off-by: Carrie Fallows <[email protected]> Signed-off-by: coleramos425 <[email protected]> Signed-off-by: David Galiffi <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Carrie Fallows <[email protected]> Signed-off-by: benrichard-amd <[email protected]> Signed-off-by: Tim Gu <[email protected]> Co-authored-by: Daniel Su <[email protected]> Co-authored-by: xuchen-amd <[email protected]> Co-authored-by: Peter Park <[email protected]> Co-authored-by: cfallows-amd <[email protected]> Co-authored-by: Cole Ramos <[email protected]> Co-authored-by: David Galiffi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ben Richard <[email protected]> Co-authored-by: Tim Gu <[email protected]> Co-authored-by: benrichard-amd <[email protected]> Co-authored-by: YANG WANG <[email protected]> Co-authored-by: Fei Zheng <[email protected]> Co-authored-by: fei.zheng <[email protected]> Co-authored-by: vedithal-amd <[email protected]>
- Loading branch information
15 people
authored
Feb 13, 2025
1 parent
9643afa
commit ac3b50f