Construct and collect CPU timer only if requested by user #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinivamd
reviewed
Aug 26, 2020
| uint32_t index = timer.CreateTimer(); | ||
| uint32_t cpuTimerIdx = 0; | ||
| if (print_cpu_time_) { | ||
| timer.InitTimer(); |
There was a problem hiding this comment.
FWIW - Please take a look at #60 on using how to compute TSCFreq just once instead of every time inside a huge triple-nested loop.
Code review could catch such issues.
There was a problem hiding this comment.
This changelist is the first part. The plan is to completely remove calls to RDTSCP and instead use Chrono library service from C++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.