-
Notifications
You must be signed in to change notification settings - Fork 101
[rocprofiler-compute] Threshold Based Clamping in Analyze Stage #2565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jamessiddeley-amd
wants to merge
21
commits into
develop
Choose a base branch
from
users/jamessiddeley-amd/threshold-based-clamping
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[rocprofiler-compute] Threshold Based Clamping in Analyze Stage #2565
jamessiddeley-amd
wants to merge
21
commits into
develop
from
users/jamessiddeley-amd/threshold-based-clamping
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sers/jamessiddeley-amd/threshold-based-clamping
…sers/jamessiddeley-amd/threshold-based-clamping
…sers/jamessiddeley-amd/threshold-based-clamping
…sers/jamessiddeley-amd/threshold-based-clamping
…sers/jamessiddeley-amd/threshold-based-clamping
…sers/jamessiddeley-amd/threshold-based-clamping
…sers/jamessiddeley-amd/threshold-based-clamping
…sers/jamessiddeley-amd/threshold-based-clamping
This reverts commit 75a670e.
…sers/jamessiddeley-amd/threshold-based-clamping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
organization: ROCm
project: rocprofiler-compute
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Multi-pass profiling collects counters across separate runs, causing derived metrics (such as A - B) to occasionally produce negative values due to run-to-run variance. Negative event counts are physically impossible and were appearing in L2 cache metrics, which was confusing users and giving invalid analysis results.
Technical Details
Implemented
NOISE_CLAMPoperation insrc/utils/parser.py:1700_l2_cache.yamlacross all gfx9 architecturesAffected metrics utilizing new
NOISE_CLAMPwrapper in soc yamls:JIRA ID
[SWDEV-566417]
Test Plan
Added 6 pytest cases (
@pytest.mark.noise_clamp):Test Result
Validated on MI350 hardware and MI300X hardware with laplacian kernel workload (the workload in which the origional negative value tickets were filed). With this new implementation, negative L2 cache values were gone, and warning only appears for >1% deviations. At the time of this PR, there is no observed metric in MI350 or MI300X for laplacian kernel workload that surpasses the 1% relative threshold variance.
ctest suite currently running
Submission Checklist