feat(dash): braille progress spinner in the job console#91
Open
michaelroy-amd wants to merge 1 commit into
Open
feat(dash): braille progress spinner in the job console#91michaelroy-amd wants to merge 1 commit into
michaelroy-amd wants to merge 1 commit into
Conversation
Job output was forwarded verbatim, so carriage-return progress redraws (pip/tqdm/huggingface) accumulated into one long horizontal line. Keep only the segment after the last CR at ingest, and show an animated braille spinner plus the parsed percentage in the running-job header, driven by a per-tick counter on the ~250ms repaint loop. Adds a pure `ui::spinner` module (frame + percent parsing) with unit tests and a CR-collapse test. Signed-off-by: Michael Roy <michael.roy@amd.com>
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Long-running job output was forwarded verbatim, so carriage-return progress redraws (pip / tqdm / huggingface) piled up into one long horizontal line in the job console.
\rat ingest (jobs::last_cr_segment), collapsing a redraw sequence to its final visible state.⠋⠙⠹…) plus the parsed percentage in the running-job status header, driven by atick_countadvanced on the existing ~250ms repaint loop.ui::spinnermodule (spinner_frame+parse_progress_pct).Tests
ui::spinner::tests: frame cycling, percent parsing (incl. rejection of out-of-range / bare%).jobs::tests: CR-collapse + plain-line passthrough.--test-threads=1), clippy-D warningsclean.Notes
Part 1 of 3 for today's dash UX work. The scrollbars PR is stacked on this branch (shared job-console render path).