Add macOS support #583
Open
Add macOS support #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ping (ROCm#550) * perf: Moved all time to pixel calculations to a seperate class for better readability and increased performance by reducing the number of individual calculations and validations across timeline_view. * fix: include <limits> header for linux compatibility. * fix: Added comments and cleaned up logic to prevent recompute on every loop. * fix: updated all components in timeline_view to use TimeToPixel convertion tool instead of function level calculations. * refactor: changed how linechart and flamechart render. No longer pass in variables but pass in the TimePixelTransform class instead. * refactor: added new transformer to arrow render process, moved all data validation to transformer and ripped out the corresponding validation from timelineview. * fix: made m_tpt a shared pointer and checked if it exists before using to prevent unexpected behavior. * Update src/view/src/rocprofvis_time_to_pixel.cpp Co-authored-by: Copilot <[email protected]> * Update src/view/src/rocprofvis_time_to_pixel.h Co-authored-by: Copilot <[email protected]> * Update src/view/src/rocprofvis_track_item.h Co-authored-by: Copilot <[email protected]> * Update src/view/src/rocprofvis_time_to_pixel.cpp Co-authored-by: Copilot <[email protected]> * refactor: created m_tpt in track_item removing from line/flame chart also fixed minor formatting errors. * fix: addressed histogram shudder on zoom level 1 while using arrow keys. also renamed variables in stickynote class to better align with new convention. * fix: added validation to prevent zooming in beyond our expressed limit. removed redundant validation on timeline_view. * refactor: moved comments around and addressed redundancy in code. * refactor: moved comments around and addressed redundancy in code. * fix: reverted the error of oversimplying logic and split simple zoom and zooming with cursor into seperate distinct functions. Also do a few more verification checks. * refactor: removed validation used for testing/development. removed redundant variables and did minor code cleanup. --------- Co-authored-by: Copilot <[email protected]>
BenWibking
requested review from
a team,
Sajeeth-Wimalasuriyan,
amokiche-amd,
drchen-amd,
tomk-amd and
vstempen
as code owners
Collaborator
|
Thank you for the contribution Ben! We are in the process of evaluating Mac Os support so it might take a bit of time to review and approve this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR enables roc-optiq to build on macOS using AppleClang.
Technical Details
sysinfo.his not available on macOS, so that is now guarded by an ifdef. Alternative Mach system calls are used on macOS.Test Plan
Manually tested on my M1 MacBook.
Test Result
It works.
Submission Checklist