Implement pytest for 07_gemm_all_scatter/gemm_all_scatter.py with import path fixes#126
Draft
Implement pytest for 07_gemm_all_scatter/gemm_all_scatter.py with import path fixes#126
Conversation
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement
Implement pytest for 07_gemm_all_scatter/gemm_all_scatter.py
Aug 30, 2025
pytest for 07_gemm_all_scatter/gemm_all_scatter.py
Collaborator
|
@copilot Check CI logs for errors. Here is one: |
… to sys.path Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Contributor
Author
... Fixed the ImportError by adding the repository root to |
Copilot
AI
changed the title
Implement pytest for 07_gemm_all_scatter/gemm_all_scatter.py
Implement pytest for 07_gemm_all_scatter/gemm_all_scatter.py with import path fixes
Aug 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements comprehensive pytest coverage for the
07_gemm_all_scatter/gemm_all_scatter.pyexample, following the established testing patterns in the repository.Changes Made
Added
tests/examples/test_gemm_all_scatter.pywith two main test functions:test_gemm_all_scatter()- Comprehensive parametrized test covering:torch.float16,torch.bfloat16,torch.float32test_gemm_all_scatter_minimal()- Basic functionality test with minimal dimensions to ensure the kernel works correctly in any MPI environment.Implementation Details
test_load_bench.pysys.pathto resolve relative imports in dynamically loaded modulesvalidate_gemm()function fromexamples/common/validation.pyBug Fixes
Fixed ImportError that occurred during test collection when dynamically importing
matmul_wrapper.py. The issue was that modules in the07_gemm_all_scatterexample contain relative imports fromexamples.commonthat weren't resolving correctly when imported viaimportlib.util. The fix adds the repository root tosys.pathbefore module import to ensure proper resolution of these dependencies.The tests will be automatically discovered and executed by the existing CI infrastructure that runs
mpirun -np <ranks> python -m pytest tests/examples/test_*.py.Fixes #61.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.