Disable lda for swizzle_a in HipBlaslt #1699
Open
+87
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengzcai
requested review from
jichangjichang,
KKyang,
vin-huang,
imcarsonliao,
hcman2,
Serge45,
Jinp800125,
TonyYHsieh,
solaslin and
a team
as code owners
| } | ||
|
|
||
| if(swizzleA && matA->ld != 0) | ||
| log_hints(__func__, |
There was a problem hiding this comment.
where did you clean or ignore lda?
There was a problem hiding this comment.
Thanks. The lda parameter is ignored (set to k) in both the initial problem and valid_args.
mengzcai
force-pushed
the
lda
branch
2 times, most recently
from
619c9ce to
a14872e
Compare
geotseng-amd
approved these changes
Feb 25, 2025
Serge45
approved these changes
Feb 25, 2025
| { | ||
| //support TN for swizzle | ||
| if(matmul_descr->op_A != HIPBLAS_OP_T && matmul_descr->op_B != HIPBLAS_OP_N) | ||
| { |
There was a problem hiding this comment.
swizzleA only need matmul_descr->op_A == HIPBLAS_OP_T
swizzleB only needs matmul_descr->op_B == HIPBLAS_OP_N
|
|
||
| // matrix A | ||
| int64_t num_rows_a = matA->m; | ||
| int64_t num_cols_a = matA->n; | ||
| int num_batches_a = matA->batch_count; | ||
| a_type = matA->type; | ||
| lda = matA->ld; | ||
| lda = (swizzleA) ? k : matA->ld; |
There was a problem hiding this comment.
should we done this in Tensile runtime but not hipblaslt runtime?
There was a problem hiding this comment.
Or done it in Tensile kernel
| } | ||
| } | ||
|
|
||
| if(swizzleA && !isValidOrderForDatatype(a_type, matA->order)) |
There was a problem hiding this comment.
seems that we need to support problem type predicate for hipblasltOrder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable lda for swizzle_a in HipBlaslt