hipblaslt flow support fp8 swizzle #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengzcai
requested review from
jichangjichang,
KKyang,
vin-huang,
imcarsonliao,
hcman2,
Serge45,
Jinp800125,
TonyYHsieh and
solaslin
as code owners
mengzcai
force-pushed
the
swizzle_client_f8
branch
2 times, most recently
from
09c3cea to
2bbe58f
Compare
| UseInitialStridesAB: false | ||
| UseInitialStridesCD: false | ||
| UseScaleAB: Scalar | ||
| UseScaleAlphaVec: 0 |
There was a problem hiding this comment.
should enable SAV for gridbase
mengzcai
force-pushed
the
swizzle_client_f8
branch
from
2bbe58f to
c0c89c9
Compare
clients/gtest/matmul_gtest.yaml
Outdated
| transB: N | ||
| alpha: 1 | ||
| beta: [ 0.0, 2.0 ] | ||
| scaleA: [2] |
There was a problem hiding this comment.
scaleA: [2] is scale vector, which should not be used.
There was a problem hiding this comment.
both scaleA:[2] and scaleB:[2] have been deleted, thanks.
clients/gtest/matmul_gtest.yaml
Outdated
| bias_vector: [0, 1] | ||
| bias_type: f16_r | ||
| unit_check: 1 | ||
| gpu_arch: '94[0-2]' |
mengzcai
force-pushed
the
swizzle_client_f8
branch
from
c0c89c9 to
13cb63b
Compare
| UseE: false | ||
| UseInitialStridesAB: false | ||
| UseInitialStridesCD: false | ||
| UseScaleAB: Vector |
There was a problem hiding this comment.
We need to support Scalar but not Vector
clients/gtest/matmul_gtest.yaml
Outdated
| M: [128] | ||
| N: [128] | ||
| K: [128] | ||
| swizzle_a: true |
There was a problem hiding this comment.
"swizzle_a: true" has been set in real_precisions_swizzleA_support, isn't it?
There was a problem hiding this comment.
yes, the redundant ones have been removed.
mengzcai
force-pushed
the
swizzle_client_f8
branch
2 times, most recently
from
638b95c to
dc3f395
Compare
Serge45
reviewed
Feb 13, 2025
mengzcai
force-pushed
the
swizzle_client_f8
branch
from
dc3f395 to
5170880
Compare
Serge45
previously approved these changes
Feb 13, 2025
clients/gtest/matmul_gtest.yaml
Outdated
| category: pre_checkin | ||
| function: | ||
| matmul: *real_precisions_swizzleA_support | ||
| M: [128] |
mengzcai
force-pushed
the
swizzle_client_f8
branch
from
5170880 to
0148ca9
Compare
mengzcai
force-pushed
the
swizzle_client_f8
branch
from
0148ca9 to
0028758
Compare
jichangjichang
previously approved these changes
Feb 13, 2025
mengzcai
force-pushed
the
swizzle_client_f8
branch
from
0028758 to
c08b1cb
Compare
add logic yamls, sample add gtest for fp16,fp8 swizzle assert1
mengzcai
force-pushed
the
swizzle_client_f8
branch
from
c08b1cb to
8eaf586
Compare
jichangjichang
approved these changes
Feb 14, 2025
boringmorning
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[----------] Global test environment tear-down
[==========] 53119 tests from 13 test suites ran. (6789418 ms total)
[ PASSED ] 53119 tests.
./build/release/clients/staging/hipblaslt-bench -r f16_r --swizzleA -m 128 -n 128 -k 128 -v --transA T --transB N --initialization rand_int
T,N,0,1,128,128,128,1,128,16384,0,128,16384,128,16384,128,16384,f16_r,f16_r,f16_r,f16_r,f32_r,0,0,0,0,0,none,0,f16_r,391.991,8.55633,10.7,0.0161795,259235,0,1e-05,1e-05
./build/release/clients/staging/hipblaslt-bench -r f16_r --swizzleA -m 129 -n 129 -k 129 -v --transA T --transB N --initialization rand_int
T,N,0,1,129,129,129,1,129,16641,0,129,16641,129,16641,129,16641,f16_r,f16_r,f16_r,f16_r,f32_r,0,0,0,0,0,none,0,f16_r,41.3222,1.0097,103.9,0.0174304,246316,0,1e-05,1e-05
./build/release/clients/staging/hipblaslt-bench -r f8_fnuz_r --c_type f16_r --d_type f16_r --swizzleA -m 128 -n 128 -k 128 -v --transA T --transB N --initialization rand_int
T,N,0,1,128,128,128,1,128,16384,0,128,16384,128,16384,128,16384,f8_fnuz_r,f8_fnuz_r,f16_r,f16_r,f32_r,0,0,0,0,0,none,0,f16_r,364.722,5.3074,11.5,0.0155591,269572,0,1e-05,1e-05
./build/release/clients/staging/hipblaslt-bench -r f8_fnuz_r --c_type f16_r --d_type f16_r --swizzleA -m 129 -n 129 -k 129 -v --transA T --transB N --initialization rand_int
T,N,0,1,129,129,129,1,129,16641,0,129,16641,129,16641,129,16641,f8_fnuz_r,f8_fnuz_r,f16_r,f16_r,f32_r,0,0,0,0,0,none,0,f16_r,248.172,4.17593,17.3,0.0113768,377380,0,1e-05,1e-05